Skip to content

fix failing api failover tests - #803

Open
lukasIO wants to merge 1 commit into
mainfrom
lukas/udpate-api-tests
Open

fix failing api failover tests#803
lukasIO wants to merge 1 commit into
mainfrom
lukas/udpate-api-tests

Conversation

@lukasIO

@lukasIO lukasIO commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

livekit/protocol#1766 caused the tests to fail

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

@stephen-derosa

Copy link
Copy Markdown
Contributor

@lukasIO i think we need to revert the upstream PR since this will be extended to a bunch of client sdks (rust included)

@ChelseaBradbury

Copy link
Copy Markdown

I think this line from the readme should also be changed:

print(e) # e.g. "SIP call failed: 486 Busy Here (resource_exhausted)"

@lukasIO

lukasIO commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

@ChelseaBradbury can you give more context on the change and why it is required? from the API's perspective this could/should be interpreted as a breaking change?

@ChelseaBradbury

Copy link
Copy Markdown

@ChelseaBradbury can you give more context on the change and why it is required? from the API's perspective this could/should be interpreted as a breaking change?

Basically ResourceExhausted isn't the right code for this, since it's likely to be interpreted as an infrastructure capacity issue rather than an expected potential call outcome. We had some discussion back and forth and we're pretty confident this isn't likely to break anything, so we decided to move forward.

@ChelseaBradbury ChelseaBradbury left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking -> docs update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants