agent simulation: record the CI pipeline a run came from - #1758
Merged
Conversation
🦋 Changeset detectedLatest commit: 3e362fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
theomonnom
approved these changes
Sep 3, 2026
u9g
force-pushed
the
jason/sim-run-source
branch
from
September 4, 2026 11:40
838a616 to
0bc4026
Compare
u9g
force-pushed
the
jason/sim-run-source
branch
from
September 4, 2026 11:44
0bc4026 to
3e362fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simulation run currently has no record of where it came from.
SimulationRun.Create.Requestcarries the project, agent, scenario group, mode and impairments, but nothing about the commit, branch, or pipeline that started the run — so a run created from a laptop and a run created by a merge queue are indistinguishable in the dashboard forever, and someone triaging a red run has no path back to the PR that caused it.This adds a
SimulationRun.CImessage, set onCreate.Request(field 13) and mirrored onSimulationRun(field 21) so it round-trips throughGetSimulationRunandListSimulationRuns.It is named
CIrather thanSourcebecausesourcealready means the uploaded agent tarball in this same scope (ConfirmSourceUpload,ConfirmSimulationSourceUpload, and "description is derived from source"); asourcefield onSimulationRunwould read as the tarball.Both fields are
optional— absent is the normal case for a run started from a laptop or the dashboard.Downstream
First of four PRs, and the only one unblocked. The others need a
github.com/livekit/protocoland@livekit/protocolrelease first:No SDK change is needed: agents (Python) and agents-js both alias the generated type verbatim (
SimulationRun = proto.SimulationRun, and a plain re-export) and neither ever creates a run, so the field appears in both on a version bump.Verification
mage proto, thengo build ./...clean andgo test ./livekit/... ./rpc/...passing.