Conversation
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #345
Summary
videoinput support for model extension nodesDependencies and review scope
This is a stacked PR on top of scene-artifact PR #357 because both use the generic typed
/generate/from-artifactroute. Until #357 merges, the diff includes its scene commit. The video-only implementation is commitc60d93df.The Pixal3D consumer also depends on shared-weight PR #348. A temporary integration merge of #348 + #357 + #358 exposed three overlapping validation conflicts (
generator_registry.py,extension-install-utils.ts, andipc-handlers.ts). The combined resolution preserves both artifact validation and node-specific shared-weight projection and passes the integration checks below. After #348 and #357 land, this branch will be rebased onto currentdev, those verified resolutions applied, and the PR marked ready.Scope
This PR deliberately supports scalar model video artifacts. It rejects video arrays, process-extension video I/O, mixed unsupported inputs, traversal, symlink/reparse escapes, file replacement after validation, and oversized files.
Validation
--noEmit,electron-vite build, andgit diff --checkpassed--noEmitpassed