Repository navigation
test(server): wait for native-main startup in Daybreak listing - #8966
Conversation
Wait for the owned fixture home to admit native-main traffic before the first Desktop listing. Pin the entitlement version across the listing sequence so the withdrawal assertion exercises the seeded grant.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Maintainer integration (lidge-jun, dev-only path in MAINTAINERS.md; dev-fix freeze exception assigned by the coordinator) at head
Follow-up worth a separate issue (not changed here): during the roughly 0.6 s native-main startup window, a Desktop listing returns 200 without the gated native rows rather than NOT RUN: full local suite, the lane=all Windows batch (left to the coordinator). |
Summary
Verification
bun test tests/server/server-new-model-policy-arrival.test.tsran five times on macOS with 15 passed and 0 failed each time.recovery-pendingand the first listing lacked the Daybreak alias (0 passed, 1 failed). With the readiness wait, releasing the held owner let the test pass. The same passing probe wrote a different runtime version to disk between listings and confirmed entitlement resolution stayed pinned (1 passed, 0 failed).bun test tests/ci-workflows/file-size-ratchet.test.ts tests/test-layout.test.tsreported 11 passed and 0 failed.bun run typecheckreported no type errors in 2,666 files.git diff --checkpassed.Checklist
Summary by CodeRabbit