Repository navigation
test(advisor): close hosted-advisor-choice fixtures before temp-home teardown - #8923
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
✅ Deterministic PR hygiene checks passed. |
|
Maintainer integration (lidge-jun, dev-only path) at head
|
Summary
e7317b6ed8. Fixture removal returnedEBUSYafter 15,179.23 ms, matching the 15-second synchronous removal retry budget. Windows 7/14 jobOPENCODEX_HOME. Async retry waits let any remaining integrity worker finish releasing its handle. The fixture uses the shared teardown timeout to cover the helper's wait budgets. The diff touches only fixture lifecycle code.Verification
bun test tests/claude-integration/claude-translated-hosted-advisor-choice.test.tspassed 15/15 once and in each of five fresh-process repetitions (90 passed, 0 failed total).lsof -a -p <bun-pid> +D <home>immediately before removal. The baseline policy Messages case failed the handle assertion. The patched file passed all 15 cases with empty handle listings and removal retries disabled.bun test tests/ci-workflows/file-size-ratchet.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.tspassed 38/38.bun test tests/lib/remove-tree-helper.test.tspassed 11/11.bun run typecheckchecked 2,569 files with zero errors.bun run privacy:scanandgit diff --checkpassed.Checklist
Summary by CodeRabbit