Skip to content

fix(windows): silence the checked-stop helper progress stream and count the pnpm owner probe in the update lint - #8917

Merged
lidge-jun merged 1 commit into
devfrom
fix/dev-red-windows-l4
Nov 18, 2026
Merged

lidge-jun merged 1 commit into
devfrom
fix/dev-red-windows-l4

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fixes two of the red Windows jobs in dev batch run 44330138319 (at 79a85fc97a):

  • windows 14/14 the PowerShell helper stops captured instances only after every proof succeeds: on a cold runner, the checked-stop task helper's Import-Module ... -Force emits a "Preparing modules for first use" progress record, which PowerShell serializes as CLIXML on stderr when output is redirected. The test requires an empty stderr, and production gains nothing from the progress stream either. The helper script (added in fix(windows): exclude foreign users from stop candidates #8817) now sets $ProgressPreference = 'SilentlyContinue' before importing, as src/link/remote-windows.ts already does.
  • windows 9/14 known-pattern lint finds no unclassified update primitive references and known-pattern helper inventory has explicit control-site contracts: fix(update): keep the configured pnpm store during update planning #8906 made the pnpm planning path prove the installed owner before the registry query, so src/update/orchestrated-entry.ts now references probeSpawnSync three times in defaultDeps (owner proof, pnpm registry query, npm/bun registry query) where the scanner's allowlist row defaults to one occurrence. Both lint cases share rawMutationViolations, which reported exactly the two extra occurrences. The scanner's occurrence table now allows three for that existing, already-reviewed row ("bounded pnpm owner and registry version probes"). These lint cases run only on Windows because the TypeScript 7 sync parser cannot start under Bun on POSIX.

Verification

  • bun test tests/windows/windows-checked-stop-live.test.ts tests/update/update-mutation-guard.test.ts: 29 pass, 3 skip (the PowerShell and TS7-parser cases are Windows-only), 0 fail on macOS.
  • bun run typecheck: no errors (2,569 files).
  • Reasoning for the lint count: the scanner keys each reference by file:context:text; all three probeSpawnSync references sit in the defaultDeps object (context <module>), and the failure lists exactly two extra allowlisted capability occurrence plus two raw primitive reference lines.
  • NOT RUN: the Windows-only cases locally (no Windows host available to this lane). ci:full is applied; the Windows confirmation comes from the next dev batch run.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Improvements
    • Stopping Windows tasks now suppresses PowerShell progress messages, keeping command output clearer. No other task-stopping behavior has changed.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 18, 2026 16:03
@lidge-jun lidge-jun added the ci:full Run the four full Ubuntu test shards on this pull request label Nov 18, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T16:05:52.584778Z 4e3340d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The PowerShell stop script now suppresses progress output. The update mutation scanner allows three probeSpawnSync occurrences in the orchestrated-entry.ts module scope and documents the pnpm behavior.

Changes: Windows task stop

Layer / File(s) Summary
Suppress PowerShell progress output
src/service/windows-task-instance-stop.ts
The script sets $ProgressPreference to SilentlyContinue.

Update mutation scanner

Layer / File(s) Summary
Adjust probe occurrence allowance
tests/helpers/update-mutation-scanner.ts
The occurrence-limit table allows three probeSpawnSync calls in the orchestrated-entry.ts module scope. Its adjacent comment describes the pnpm branch’s owner check and registry query; npm and bun retain an allowance of one.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related PRs

  • lidge-jun/opencodex#8573: Wires the Windows stop helper into stop paths, including the updater path that uses the helper changed here.
  • lidge-jun/opencodex#8564: Adds checked-stop primitives that use the PowerShell helper changed here.
  • lidge-jun/opencodex#8109: Changes update-lint findings for orchestrated modules, which are related to the scanner allowance adjusted here.

Suggested reviewers: luvs01

Merge Risk: Minimal · up to 4e334

This change silences a PowerShell progress message on Windows task stop and adjusts a test-only lint allowance. Production impact is negligible, and it is ready to merge once the next Windows CI run confirms it.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names two changes: silencing progress output in the checked-stop helper and counting the pnpm owner probe in the update lint. The raw summary describes only the PowerShell $ProgressPreferenc…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names two changes: silencing progress output in the checked-stop helper and counting the pnpm owner probe in the update lint. The raw summary describes only the PowerShell $ProgressPreference change and a lint allowance table change. The summary does not mention a fix(windows) scope beyond the PowerShell script, so the title's first clause matches. The second clause matches the lint allowance change. The title is long at 111 characters and 17 words, but it is specific and related to the changeset. It also covers the main points of the PR objectives.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 819468c and 4e3340d.

Files selected for processing: 2

  • src/service/windows-task-instance-stop.ts
  • tests/helpers/update-mutation-scanner.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

@github-actions github-actions Bot added the intake: hygiene-blocked Deterministic PR hygiene checks failed label Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added bug Something isn't working and removed intake: hygiene-blocked Deterministic PR hygiene checks failed labels Nov 18, 2026
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration (lidge-jun, dev only) at head 4e3340d4cc, as the assigned dev-fix exception to the current merge freeze (dev batch run 44330138319 items 2 and 3). Branch is current with dev. All PR checks green on this head, including the full Ubuntu shards (ci:full). Independent review (gpt-6.2-sol): no source findings. It reproduced the update lint with TypeScript 7.0.2: the parent scanner reports exactly the two excess probeSpawnSync occurrences, this head accepts the three, and a fourth is still rejected. It also confirmed that $ProgressPreference suppresses only the progress stream, while $ErrorActionPreference = 'Stop' still governs errors. assert-mergeable-review.sh --maintainer-integration 8917 OK. The Windows-only cases are confirmed by the next dev batch run.

@lidge-jun
lidge-jun merged commit e7317b6 into dev Nov 18, 2026
41 of 46 checks passed
@lidge-jun
lidge-jun deleted the fix/dev-red-windows-l4 branch November 18, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci:full Run the four full Ubuntu test shards on this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant