Repository navigation
fix(windows): silence the checked-stop helper progress stream and count the pnpm owner probe in the update lint - #8917
Conversation
…in the update lint
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
✅ Deterministic PR hygiene checks passed. |
|
Maintainer integration (lidge-jun, dev only) at head |
Summary
Fixes two of the red Windows jobs in dev batch run 44330138319 (at
79a85fc97a):the PowerShell helper stops captured instances only after every proof succeeds: on a cold runner, the checked-stop task helper'sImport-Module ... -Forceemits a "Preparing modules for first use" progress record, which PowerShell serializes as CLIXML on stderr when output is redirected. The test requires an empty stderr, and production gains nothing from the progress stream either. The helper script (added in fix(windows): exclude foreign users from stop candidates #8817) now sets$ProgressPreference = 'SilentlyContinue'before importing, assrc/link/remote-windows.tsalready does.known-pattern lint finds no unclassified update primitive referencesandknown-pattern helper inventory has explicit control-site contracts: fix(update): keep the configured pnpm store during update planning #8906 made the pnpm planning path prove the installed owner before the registry query, sosrc/update/orchestrated-entry.tsnow referencesprobeSpawnSyncthree times indefaultDeps(owner proof, pnpm registry query, npm/bun registry query) where the scanner's allowlist row defaults to one occurrence. Both lint cases sharerawMutationViolations, which reported exactly the two extra occurrences. The scanner's occurrence table now allows three for that existing, already-reviewed row ("bounded pnpm owner and registry version probes"). These lint cases run only on Windows because the TypeScript 7 sync parser cannot start under Bun on POSIX.Verification
bun test tests/windows/windows-checked-stop-live.test.ts tests/update/update-mutation-guard.test.ts: 29 pass, 3 skip (the PowerShell and TS7-parser cases are Windows-only), 0 fail on macOS.bun run typecheck: no errors (2,569 files).file:context:text; all threeprobeSpawnSyncreferences sit in thedefaultDepsobject (context<module>), and the failure lists exactly twoextra allowlisted capability occurrenceplus tworaw primitive referencelines.ci:fullis applied; the Windows confirmation comes from the next dev batch run.Checklist
Summary by CodeRabbit