Repository navigation
fix(antigravity): let a verify-account hop's 5xx replacement take the one fault hop - #8846
Conversation
… one fault hop The verify-account 403 hop loop re-entered recovery only for non-replayable responses, so a replayable 502/503/504 from the replacement account left the loop and the one-hop 5xx sibling rotation never ran: A:403 verify -> B:503 failed without trying C. The hop now asks isAntigravityFaultRotatable, the same guard the 429 hop uses since #8839, still once per request. Follow-up to #8839 (CodeRabbit thread PRRT_kwDOS-0Gi863wcE0 on #8778).
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Maintainer integration of #8846 at 4a10f49. It closes the follow-up gap noted on #8839: the verify-account 403 hop had the same shape as the 429 hop.
|
Summary
On a Google Antigravity account pool, a verify-account 403 on account A rotates to sibling B. If B then returned a replayable 502, 503 or 504 that outlived its same-account retries, the request failed with that 5xx and never tried C. The verify-account hop loop re-entered recovery only for non-replayable responses, so the one-hop 5xx sibling rotation never saw B's failure. #8839 fixed the same gap for the 429 hop.
src/server/responses/adapter-dispatch.ts: the verify-account hop now also re-enters recovery whenisAntigravityFaultRotatable(fromantigravity-fault-rotation.ts) holds for the replacement. The one-hop guard still limits the fault rotation to once per request. Line count is unchanged at 1,991.tests/server/server-google-antigravity-oauth-401-replay.test.ts: new caseA:403 verify-account → B:503 ×3 → C:200. It asserts the send order, that C's project carries the answer, that A keeps itsverify_accountquarantine, that B is cooled but not marked, and that the attempt records both theoauth-account-403andtransient-5xxrecovery kinds.antigravity-fault-rotation.tsrow instructure/transports/responses.md, and the en and esreference/configuration/providers.md5xx paragraph now say the replay also covers a 5xx from the sibling that a 429 or verify-account hop reached.Follow-up to #8839 (CodeRabbit thread PRRT_kwDOS-0Gi863wcE0, left on #8778).
Verification
origin/dev(950b7d9) with only the test added:bun test tests/server/server-google-antigravity-oauth-401-replay.test.ts -t 'verify 403 hop whose sibling'failed. The sends wererejected-access, access-b ×3andaccess-cwas never tried.server-google-antigravity-oauth-401-replay,server-antigravity-verify-replay-scope,server-google-antigravity-oauth-429-budget,oauth/generic-oauth-failover,server-antigravity-web-search-validation: 179 pass, 0 fail.responses-core-modules,responses-reasoning-effort-downgrade,file-size-ratchet: 160 pass, 0 fail.docs-spanish-localization,docs-link-targets(with the 401-replay file): 107 pass, 0 fail.bun run typecheck,bun run structure:check,bun run privacy:scan: pass./usr/bin/lockf -k /tmp/ocx-test.lock. The full suite was not run locally (concurrent worktrees on this host);ci:fullcovers it.Checklist
Summary by CodeRabbit
fetchcan also fail over after supported 403 rejections.