Repository navigation
refactor(types): move routing-profile config types out of src/types/config.ts - #8830
Conversation
…ting-profile.ts Pure move of the ten routingProfiles declarations out of src/types/config.ts, re-exported from config.ts so no import site changes. Restores headroom under the 2,000-line file-size ratchet (1,996 -> 1,912 lines).
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Maintainer integration of #8830 at fa0cbeb.
|
Summary
src/types/config.tsis 1,996 lines ondev. The file-size ratchet fails any untracked file that reaches 2,000 lines, and queued #8788 adds 4 lines to it, which would put it at exactly 2,000 and turn the ratchet red.This moves the ten
routingProfilesdeclarations (OcxRoutingProfileConfigand the nine types it is built from, 88 lines with their doc comments) into a new sibling module,src/types/routing-profile.ts. The group is self-contained: it references nothing else inconfig.ts, andconfig.tsuses it only for theroutingProfilesfield.config.tsimportsOcxRoutingProfileConfigfor that field and re-exports all ten names, so no import site changes.It is a pure move. The moved block is byte-identical to lines 1578–1665 of
origin/dev(checked withdiff), with no renames and no behaviour change.config.tsdrops from 1,996 to 1,912 lines.A small source test,
tests/config/routing-profile-types-reexport.test.ts, guards the re-export contract:config.tsmust re-export exactly the namesrouting-profile.tsdeclares and must not re-declare any of them, androuting-profile.tsmust stay import-free. It is registered inscripts/test-layout/layout-config.json(at the top of the file, so it does not collide with #8788's append) andtests/fixtures/test-layout-expected.json.structure/manifest.jsonalready ownssrc/types/at directory level, and no structure doc names the file holding these types, so no structure update was needed.Verification
All test commands ran under
/usr/bin/lockf -k /tmp/ocx-test.lockbecause the machine is under heavy load.bun run typecheck: no type errors in 2,552 files.bun run structure:check: structure/ SSOT checks passed.bun test tests/config/routing-profile-types-reexport.test.ts tests/ci-workflows/file-size-ratchet.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts: 41 pass, 0 fail.git merge-tree --write-tree HEAD origin/pull/8788/head: clean, no conflicts. The mergedsrc/types/config.tsis 1,916 lines.Not run: the full
bun run testsuite, because of host load. The source change is type-only and the typecheck covers every import site; CI'stest changedcovers the import graph.Checklist
Summary by CodeRabbit