Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
3 tasks done
Contributor
|
✅ Deterministic PR hygiene checks passed. |
3 tasks done
lidge-jun
added a commit
that referenced
this pull request
Nov 17, 2026
…nclude, Command Code root schemas, JEV continuation effort (#8873) Lane R3 of the 2026-11-17 triage round: rewrite the Claude Code sentences Cognition refuses for Devin (#8703), normalize the OpenCode Go output include (#8827), normalize root tool schemas for Command Code's Claude upstreams (#8591), and keep JEV's decided effort through tool-loop continuations (#8861, continuation fix only), with review follow-ups. Co-authored-by: 袁威豪 <137183806+jhl880617@users.noreply.github.com> Co-authored-by: Ingwannu <186453546+Ingwannu@users.noreply.github.com> Co-authored-by: Mursyid <ciddhere@gmail.com> Co-authored-by: tachyon6 <songjunjun62754@gmail.com>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #8702.
OpenCode Go multiplexes Responses backends with different
includesupport. A Codex App request containing the optionaloutput.encrypted_contententry can receive a 400 before inference. Reuse the existing exact Go final-URL predicate and shared include cleanup to omit only that entry athttps://opencode.ai/zen/go/v1/responses, across its models.reasoning.encrypted_content, other/unknown entries, malformed values, caller input and existing reasoning history. Omitincludeif removal leaves an empty array.Verification
Base:
da021e37dc15ba740aaca05fd4fd125c12df578e(devwas still identical immediately before publication). Bun 1.4.4, Linux, ubuntu UID/GID 1000, isolated worktree and fresh temporary HOME/CODEX_HOME/OPENCODEX_HOME/TMPDIR; one local workload at a time under cgroup CPU/memory/swap/process/time caps.bun test tests/providers/opencode-go-grok46-responses.test.ts: 44 pass / 4 fail, the newly asserted output-include cleanup fails on the actual emitted request.bun test tests/providers/opencode-go-grok46-responses.test.ts tests/responses/responses-muse-tool-choice.test.ts tests/adapters/openai/openai-empty-assistant-history.test.ts: 104 pass / 0 fail, 414 assertions. Includes multiple Go model families, reasoning/unknown-entry preservation, non-mutation, empty/malformed includes and unrelated destination controls. Existing final-URL predicate controls cover credentials, query/fragment and wrong resources.bun check --no-script --noEmit: 2,549 files, no type errors.bun test tests/ci-workflows/structure-ssot.test.ts tests/ci-workflows/file-size-ratchet.test.ts tests/ci-workflows/docs-spanish-localization.test.ts: structure 51 pass, ratchet 9 pass. Spanish initially failed on the added external-link parity; after updating the Spanish contract,bun test tests/ci-workflows/docs-spanish-localization.test.ts: 30 pass / 0 fail. No ratchet baseline increased.git diff --check: passed.bun install --frozen-lockfile --ignore-scriptsfor root, GUI type dependencies and docs: passed. No lockfile or manifest changes.bun run --cwd docs-site build: not completed. Astro generated pages/images, then the Starlight/Pagefind integration did not finish within the fixed 300-second local envelope and was terminated by the cgroup service timer. No limit increase or unbounded retry. Complete docs build remains for hosted CI.Resource exception / remaining coverage: the repository-wide import graph is disproportionate to this one optional-field compatibility correction on this shared development host. Focused behavioral tests, typecheck and structural/localization gates are recorded above; the full and changed suites were not run. Required hosted CI, complete docs build and owner review remain pending, so this stays Draft. No native Windows/macOS run, paid provider/model call, real credential operation or live Codex App end-to-end verification was performed. Fixture success does not certify all upstream models.
Checklist