Repository navigation
test(update): admit the package launcher's ocx update --desktop refusal in the update lint allowlist - #8824
Conversation
…usal in the update lint allowlist #8795 added a second pre-mutation process.exit(64) to bin/ocx.mjs: the package launcher refuses 'ocx update --desktop' before Desktop handoff, boot restore or any install. The Windows-only known-pattern update lint allowlisted exactly one occurrence, so dev lane=all 43840762595 failed windows 9/14 (both update-mutation-guard lint cases). The lint skips where its TypeScript parser cannot open (Ubuntu PR CI), which is why the exact-head CI for #8795 was green.
|
✅ Deterministic PR hygiene checks passed. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Maintainer integration of #8824 at e5a2577.
The full windows shard 9/14 run on the same host is still going, and the next batched |
Summary
devbatch run 43840762595 (858ea8d) failed windows 9/14 intests/update/update-mutation-guard.test.ts. Two cases failed, "known-pattern lint finds no unclassified update primitive references" and "known-pattern helper inventory has explicit control-site contracts", each reporting:#8795 added a second
process.exit(64)at module level inbin/ocx.mjs(line 1346). There, the package launcher refusesocx update --desktop, because only a Desktop installation's ownocx.execan run it. The refusal comes before the Desktop handoff, the boot restore and any install-capable step, so it is the same pre-mutation exit class as the existing usage refusal at line 1378. The update lint's allowlist admitted exactly onebin/ocx.mjs:<module>:process.exit(64). This change raises that entry's occurrence limit to 2 and names both refusals in its reason. No other entry changes.The lint runs only on Windows:
openUpdateLintParserreturns null, andlintTestskips, where its TypeScript parser cannot open. That covers the Ubuntu PR shards, which is why #8795's exact-head CI was green. The previous batch run, 43832690786, stopped this shard at batch 4/42 on the lock failure fixed in #8823, so this case was not reached there.Verification
tests/helpers/update-process-allowlist.ts(the count goes from 1 to 2 and the reason is extended).scripts/ci/run-bun-test-batches.sh.lane=allon dev after merge is the CI evidence for Windows.Checklist
Summary by CodeRabbit