Repository navigation
fix(adapters): avoid Gemini rejection of tool catalog guidance - #8792
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
✅ READY
Review readiness checklist
✅ 4/4 boxes ticked. This pull request has been marked Ready for Review. Hygiene✅ Deterministic PR hygiene checks passed. |
Ingwannu
left a comment
There was a problem hiding this comment.
Reviewed the complete five-file diff at fd12d96ea11cc8b3744b9387d2f9ed538d7e4ada. The replacement sentence retains the declared-tool boundary, wire names and nested-helper semantics, and the Google wire tests cover both the ordinary catalog and code-mode request. The owning documentation explains the compatibility intent without changing quota handling.
Hosted Ubuntu CI 43795503958 passed, including the actual Google adapter/nudge tests and docs build. This supports the narrow wording change. It does not establish why the reported account received a 429 or demonstrate that this prevents account restrictions. Approval is for this head; refresh stale dev ancestry/readiness before integration. No live account or model call was made.
|
Maintainer integration into
|
…guard, Spanish adapters parity) (#8874) * docs(es): add the Gemini tool-catalog guidance line to the Spanish adapters reference #8792 added a reference/adapters.md bullet naming `429 RESOURCE_EXHAUSTED`; its PR CI predated the Spanish localization identifier check, so dev now fails docs-spanish-localization. This adds the matching Spanish bullet. * fix(tests): let the network guard pass WebSocket over Unix sockets #8872 refused every scheme outside http(s)/ws(s)/data/blob/file, which included ws+unix:. Local and remote messaging reach their daemon through ws+unix:// WebSockets, so the guard rewrote them to its refused socket and the messaging suites failed on dev with daemon_unavailable and remote_control_unknown. ws+unix: and wss+unix: never leave the machine, so they are allowed like data:, blob: and file:.
Adapt upstream lidge-jun#8792 for Cloud Code Assist while retaining other providers prompt bytes. Co-authored-by: zhuxt2015 <13765310+zhuxt2015@users.noreply.github.com>
Summary
429 RESOURCE_EXHAUSTEDbecause of one sentence injected by the shared tool-catalog nudge. In live same-account probes, plain requests and disabled tools succeeded; the original sentence alone reproduced the refusal, while the replacement succeeded in both ordinary and Codex code-mode prompts.ALL_TOOLSdiscovery and the code-mode host contract remain unchanged. No error classification, quota handling, credential or routing changes.Verification
bun test tests/adapters/tool-catalog-nudge.test.ts tests/adapters/google/google-adapter.test.ts: red/green confirmed. The unpatched source failed the four updated/new wording assertions; the patched source passed all 80 tests.fd12d96,bun run typecheck: no type errors in 2,536 files.bun test tests/adapters/tool-catalog-nudge.test.ts tests/adapters/google/google-adapter.test.ts tests/adapters/google/google-tool-schema-contract.test.ts tests/adapters/google/google-tool-result-adjacency.test.ts tests/adapters/google/google-signature-history-roundtrip.test.ts tests/providers/kiro/kiro-tool-catalog.test.ts tests/ci-workflows/structure-ssot.test.ts: 260 passed, 0 failed.bun run privacy:scanandbun run structure:check: passed.function_call-> local execution ->function_call_outputcontinuations each returned an unpredictable result exactly; a real Codex Gemini subagent executedpwdand a diagnosticprintfthroughexec->tools.exec_command, both exit code 0. These are manual upstream compatibility probes, not claims that an offline mock can enforce Google's acceptance policy.bun run test:changedwas attempted but did not complete in the sparse/partial checkout and was interrupted; not reported as passing. The full suite was not run: importing the shared nudge fans out across adapters and the resource/sparse-checkout cost is disproportionate to this one-line compatibility change. Focused semantic and wire tests above passed; broader Ubuntu and cross-platform coverage remains to CI.cd docs-site && bun install --frozen-lockfile && bun run build: passed; 775 pages built, 117,814 internal links checked.devate87572127d7804216ebfcf0feecaf4c22c181748before push. Independent review found no blocking semantic issue in the wording change.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit