Repository navigation
fix(link): run the served install for Windows link sync and update planning (#8359) - #8781
Conversation
…anning (#8359) The pinned and overwrite syncs and the gated update plan on Windows now read the first serving-runtimes record like discovery and inspection, so a stale bun-global ocx can no longer answer their version gate. To fit the census under the cmd.exe command line, the packed payload now carries 14 bits per character (U+3400..U+73FF) with its byte count instead of one byte per character, cutting about 2,000 characters from every Windows command. Test decoders share windowsInflatedScript.
The Windows host showed the gated scripts handing bun.exe the version parts: the gate loop reassigns $a, which also held the served entry. The served candidate now uses $sx and $sy, which nothing else assigns.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Security review (merge manager's reviewer) at 28b624e: MERGE, no security or functional blocker.
Follow-ups (not blocking): stale comments at Windows-only behavior (decoder, C# helper, served-pair tests, variable-reuse regression, CLM exit 126, kill on channel drop) is first exercised by the batched |
|
Merge-manager note on the |
…test (#8359) The longest valid Home version now fits the Windows plan probe, so the test drove the windows-command-too-long mapping through a builder that no longer overflows. It now injects the builder error and checks the longest version builds.
|
Merge-manager note: the |
|
Maintainer integration of #8781 at 2ccd824 (closes #8359).
|
Summary
On Windows,
ocx link sync(pinned and overwrite) and update planning still picked the first runnable Desktop/PATHocx. A stale bun-globalocx.execould answer their version gate even though another install serves the Child. #8769 fixed discovery andocx link probe; this PR fixes the rest of #8359 (step 3 of its plan).windowsGatedOcxArgv(update plan) andwindowsOverwriteSyncArgv(pinned and overwrite sync) now read the same firstserving-runtimes.jsonrecord as discovery. The served install, including an npm[bun.exe, cli\index.ts]pair, comes first and answers the version gate. A runnableocx-childstill comes first while the Child has lightweight state, and the Windows plan probe still reports entrybinary(Windows never applies).windowsInflatedScript. The Windows served-home fixture moved totests/helpers/windows-served-home.ts.windows-command-too-longerror is still tested with an argument that cannot fit, andlink-child-observenow injects that builder error to cover itsfailedmapping (2ccd824271; PR shard 1 caught the old version).Closes #8359
Verification
Failing tests came first. The three new Windows behavior tests fail against
origin/dev'sremote-windows.tson the Windows host, because Bun's own version fails the gate (exit 121). The packing-alphabet and budget-headroom tests failed locally before the change.Windows 11 (build 26200.9974, Bun 1.3.14, GOAT host
desktop-c795oh4), at28b624e3db:bun.exeentry pair.(#8359)discovery and inspection tests pass.ocx, the per-builder cannot-be-contained refusals, constrained containment probes, and the inflated script's own errors staying unrelabelled.origin/dev: it overruns the 5 s default timeout, and Bun 1.3.14 returns EFAULT when it removes a directory junction.origin/dev'sremote-windows.ts, all three new gated tests fail with exit 121.f463d96e71) failed those three tests on Windows because the served entry shared$awith the gate loop's version parts.28b624e3dbmoves it to$sx/$sy.f463d96e71, three link-recover "tombstone bound" tests timed out; they fail the same way onorigin/dev7b4b3958d.macOS (Bun 1.4.4), light checks only because the host is under critical load:
bun testonlink-windows-gated-served,link-ssh-argv-discovery,link-gated-ocx-argv,link-pinned-sync-overwrite,link-pinned-sync-argv,link-ephemeral-child-discovery,link-child-plant-foundations,link-recover,link-enrollment: 290 pass / 23 skip / 0 fail.bun run typecheck: exit 0.bun run structure:check: passed.bun run privacy:scan: passed.docs-spanish-localization,test-layout,test-layout-toolingandfile-size-ratchettests: 68 pass / 0 fail.NOT RUN:
bun run test:changedand the full suite locally (this Mac is at critical load; PR CI runstest changed).NOT RUN:
lane=all(left to the batcheddevdispatch per CI policy).Checklist
structure/remote-link.md; docs-site Remote Link guide in English and Spanish.)Summary by CodeRabbit