Skip to content

docs(es): restore Spanish adapters parity after #8590 - #8765

Merged
lidge-jun merged 1 commit into
devfrom
fix/es-adapters-devin-data-surfaces
Nov 15, 2026
Merged

lidge-jun merged 1 commit into
devfrom
fix/es-adapters-devin-data-surfaces

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

dev is red at 4cbe4be: #8590 added a OPENCODEX_DEVIN_SANITIZE_DATA_SURFACES paragraph (plus a field #2 sentence) to the English docs-site/src/content/docs/reference/adapters.md, and the Spanish page had no counterpart. tests/ci-workflows/docs-spanish-localization.test.ts then fails two cases on every branch tested against dev ("keeps executable examples and frontmatter in the current English shape" — missing inline identifiers; "preserves external links, references…" — missing #6 etc.). First seen on #8429's full lane: https://github.com/lidge-jun/opencodex/actions/runs/43676018062/job/132700405950

This adds the Spanish translation of the same two pieces to docs-site/src/content/docs/es/reference/adapters.md, with the same code spans (OPENCODEX_DEVIN_SANITIZE_DATA_SURFACES, "1", arguments_json) and the same Cognition request field numbers as the English page.

#8590's own CI passed because the Spanish parity test reads docs as data, which the import-graph test changed lane does not reach.

Verification

  • bun test tests/ci-workflows/docs-spanish-localization.test.ts: see the comment below for the local result; this PR carries ci:full so the full Ubuntu lane runs the parity test.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults (docs only).

Summary by CodeRabbit

  • Documentation
    • Clarified that known trigger rewrites also apply to the initial system prompt.
    • Documented an opt-in setting to sanitize additional message content, including tool arguments, image captions, and echoed reasoning. Unchanged reasoning retains its original signature; rewritten reasoning does not.

The Spanish text translates the English paragraph #8590 added, so its author is credited.

Co-authored-by: Epinephrine luvs01@hanmail.net

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 15, 2026 04:43
@lidge-jun lidge-jun added documentation Improvements or additions to documentation ci:full Run the four full Ubuntu test shards on this pull request labels Nov 15, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T04:44:50.271822Z 676b5f5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Spanish adapter reference now documents rewriting known triggers in the initial system prompt and describes the OPENCODEX_DEVIN_SANITIZE_DATA_SURFACES option and its effects.

Changes

Cohort / File(s) Summary
Devin documentation
docs-site/src/content/docs/es/reference/adapters.md
Documents the exact "1" enablement value, the additional text surfaces that sanitization can rewrite, and how rewritten reasoning affects signature metadata. It also clarifies that tool names, tool IDs, and image bytes are unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: Minimal · up to 676b5

This change adds a Spanish documentation paragraph that matches the English reference and the adapter behavior. It has no runtime impact and is ready to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "docs(es): restore Spanish adapters parity after #8590" matches the changeset, which updates the Spanish adapters reference (docs-site/src/content/docs/es/reference/adapters.md) to add the O…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "docs(es): restore Spanish adapters parity after #8590" matches the changeset, which updates the Spanish adapters reference (docs-site/src/content/docs/es/reference/adapters.md) to add the OPENCODEX_DEVIN_SANITIZE_DATA_SURFACES paragraph and related text. It names the file area (Spanish adapters docs) and the purpose (parity after #8590). The title is specific and uses a conventional docs prefix. It does not spell out the translation of the sanitizer note, but it still refers to the main change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 6a8e862 and 676b5f5.

Files selected for processing: 1

  • docs-site/src/content/docs/es/reference/adapters.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

@github-actions github-actions Bot added the intake: hygiene-blocked Deterministic PR hygiene checks failed label Nov 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Deterministic hygiene checks failed.

  • missing_coauthor_credit — This pull request says it reimplements, supersedes, carries, or rebases another author's pull request, but no Co-authored-by trailer names that author. Prose in a commit body is not read by anything; the trailer is what GitHub counts. Add it to the description or a commit, or obtain attribution-approved. Paths: #10, #2, #3.

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

✅ READY

  • this PR is ready for review.

Hygiene

✅ Deterministic PR hygiene checks passed.

@github-actions
github-actions Bot marked this pull request as draft November 15, 2026 05:12
@github-actions github-actions Bot removed the intake: hygiene-blocked Deterministic PR hygiene checks failed label Nov 15, 2026
@github-actions
github-actions Bot marked this pull request as ready for review November 15, 2026 05:14
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration (merge manager): dev repair for the batch that merged #8590.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:full Run the four full Ubuntu test shards on this pull request documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant