Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
✅ Deterministic PR hygiene checks passed. |
|
Closing as superseded. The route-intent scenario children now import via #8707 (696c7b5), which removes the real Windows ACL process cost this PR targeted. The afterAll timeout turned out to have a different cause, fixed by #8710 (e3d4694): did not stop the local-credential observer, whose handles blocked sandbox deletion on Windows. Maintainer judgment: close without merging. This branch conflicts with dev and would add a second ACL helper. |
Summary
Windows shards of two dev batches timed out in the route-intent tests added by #8416 (
f23910ab2d):Affected cases include
tests/clients/route-intent-connected.test.ts(40 s each; "connect inherits non-native intent…", "explicit provisioning selection survives…", "local off persists across sync…", "promoted public aliases preserve file ids…" and others) andtests/clients/route-intent-file-originals.test.ts("a local opt-out of a pre-owned integration…"). Intests/clients/route-intent-runtime-stop.test.ts, the assertion passed and then a cleanup hook timed out; the 480 s batch timeout followed. Even the passing Windows cases took 23–39 s.Each scenario spawns a Bun child that writes config, lifecycle and link state without installing the ACL fakes the parent tests use. On Windows every such write runs real
icaclshardening and principal lookups. With a Windows ACL path injected on Linux, one connected scenario issued 198 ACL commands (120 on the config directory, 72 on the lifecycle database, 6 on link paths) before hitting its 40 s subprocess timeout. A slow asynchronous ACL runner reproduced the runtime-stop cleanup hang, withconfig-dir-acl-hardenstill pending.tests/helpers/route-intent-acl-fixture.tsinstalls the synchronous and asynchronous icacls fakes and a Windows principal fake, the same seams other fixtures use, and each child calls it before any config write. Assertions and timeout budgets are unchanged; no product behavior changed.Verification
bun test tests/clients/route-intent-connected.test.ts tests/clients/route-intent-file-originals.test.ts tests/clients/route-intent-runtime-stop.test.ts: 34 pass, 0 fail.bun run typecheck: exit 0.bun run test:changed: 34 pass, 0 fail.Checklist
Summary by CodeRabbit