Repository navigation
Conversation
…very mock test 5/5 of dev batch 43451726885 failed both CLI cases of tests/clients/route-intent-connect-recovery.test.ts: the child script replaced src/client/connect with a fixed four-function object, and since #8662 src/cli/connect.ts also imports assertDisconnectExpectation from it, so the mocked module failed to link (SyntaxError: Export named 'assertDisconnectExpectation' not found). Spread the real module and fake only the connection actions; 0/2 -> 9/9 in the file.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Closing as a duplicate: #8700 (already merged) applies the same fix to tests/clients/route-intent-connect-recovery.test.ts, spreading the real client connect module in the mock, and its owner asked this lane not to touch that file. |
Summary
test 5/5of dev batch run 43451726885 (job), which the release is waiting on, failed both CLI cases oftests/clients/route-intent-connect-recovery.test.ts(:43 "Hub rejects generic clients before reading a credential or attempting connect", :56 "Link accepts generic clients and completion uses the effective connection selection"). The child exited 1 with:The cases came with #8416 (
f23910ab2d). Their child script replacedsrc/client/connectwith a fixed four-function object. #8662 (63c7da75bb) madesrc/cli/connect.tsalso importassertDisconnectExpectationfrom that module, so the mocked module no longer satisfied the CLI's imports. Product code is correct; the mock was closed over an export list.The mock now spreads the real module and fakes only the four connection actions it faked before, so exports the CLI adds later still link. No assertion changed. No other test mocks this module.
Verification
65ec0dd22e:bun test tests/clients/route-intent-connect-recovery.test.tsgives both cases failing with the sameSyntaxError. With this change: 9 pass, 0 fail.bun run typecheck: exit 0.Checklist
Summary by CodeRabbit