Skip to content

test(link): journal the Codex catalog path exactly as the fixture writes it - #8693

Merged
lidge-jun merged 1 commit into
devfrom
fix/dev-red3-route-intent-windows-b
Nov 13, 2026
Merged

lidge-jun merged 1 commit into
devfrom
fix/dev-red3-route-intent-windows-b

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

windows 8/14 of dev batch run 43413601225 failed tests/clients/client-disconnect-edited-codex.test.ts:72 "disconnect preserves post-injection edits and relink baseline (Windows text: %s)". It got "disconnect refused: Codex journal restore was partial…". The case came with #8416 (f23910ab2d). The fixture writes the catalog at join(codex, "opencodex-catalog.json") (backslashes on Windows) but recorded c + "/opencodex-catalog.json" in the journal. On Windows the two strings differ, so the ownership check correctly refused to restore a path it did not recognize.

The journal now records the same joined path the fixture writes. No restoration assertion and no product behavior changed. Test-only.

Verification

  • Reproduced the comparison on Linux: restoreJournalConfigFields with a Windows backslash catalog path and the fixture's mixed-separator journal value returns null (refused). With path.win32.join on both sides it restores.
  • bun test tests/clients/client-disconnect-edited-codex.test.ts: 4 pass, 0 fail. bun run typecheck: exit 0.
  • NOT RUN: a native Windows runner (next dev batch), and the full suite.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Tests
    • Updated a disconnect test fixture to use the same catalog path as its configuration. The tests continue to cover Windows and non-Windows text, changed owned URLs, and hashless journals.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 13, 2026 13:37
@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T13:38:23.359948Z 86f0dbc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Nov 13, 2026
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The disconnect test fixture now builds injectedCatalogPath with join(codex, "opencodex-catalog.json") instead of manual path concatenation.

Changes: Disconnect test fixture

Layer / File(s) Summary
Build the catalog path
tests/clients/client-disconnect-edited-codex.test.ts:44
The journal fixture uses join to build injectedCatalogPath.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · up to 86f0d

This is a test-only fixture fix that aligns the recorded catalog path with the written file on Windows. It does not change product behavior, and no merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the change: the test fixture's journal entry now records the Codex catalog path exactly as the fixture writes it. The raw summary confirms the only change is in tests/clients/client-di…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: the test fixture's journal entry now records the Codex catalog path exactly as the fixture writes it. The raw summary confirms the only change is in tests/clients/client-disconnect-edited-codex.test.ts, where injectedCatalogPath is set with join(codex, ...) to match the fixture's config. The PR objectives describe the same fix for the Windows mixed-separator path that made the ownership check refuse restoration. The title is specific and matches the main change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between ee0098a and 86f0dbc.

Files selected for processing: 1

  • tests/clients/client-disconnect-edited-codex.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer judgment (dev integration, MAINTAINERS.md maintainer-integration exception): merging without a second maintainer approval, as part of the DEV-RED repair for dev batch run 43413601225 (windows 8/14).

  • Exact head: 86f0dbc994e19954fc50fbc98b7734856130ab3a. Every required PR check on this head passed.
  • Fresh independent review on this exact head (gpt-6.1-terra, high): VERDICT: PASS, no findings. It confirmed production injection journals the same selected catalog path it writes, so the fixture's mixed-separator journal was unrealistic. Its fresh runs: client-disconnect-edited-codex 4 pass / 0 fail on the pinned Bun 1.4.4; typecheck exit 0.
  • Classification: test-fixture bug from feat(link): sync route intent and materialize clients per device (re-land #8276) #8416. Test-only; restoration stays conservative.
  • No outstanding change requests.

@lidge-jun
lidge-jun merged commit e723ff5 into dev Nov 13, 2026
31 checks passed
@lidge-jun
lidge-jun deleted the fix/dev-red3-route-intent-windows-b branch November 13, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant