Repository navigation
test(link): journal the Codex catalog path exactly as the fixture writes it - #8693
Conversation
|
✅ Deterministic PR hygiene checks passed. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Maintainer judgment (dev integration, MAINTAINERS.md maintainer-integration exception): merging without a second maintainer approval, as part of the DEV-RED repair for dev batch run 43413601225 (windows 8/14).
|
Summary
windows 8/14 of dev batch run 43413601225 failed
tests/clients/client-disconnect-edited-codex.test.ts:72"disconnect preserves post-injection edits and relink baseline (Windows text: %s)". It got "disconnect refused: Codex journal restore was partial…". The case came with #8416 (f23910ab2d). The fixture writes the catalog atjoin(codex, "opencodex-catalog.json")(backslashes on Windows) but recordedc + "/opencodex-catalog.json"in the journal. On Windows the two strings differ, so the ownership check correctly refused to restore a path it did not recognize.The journal now records the same joined path the fixture writes. No restoration assertion and no product behavior changed. Test-only.
Verification
restoreJournalConfigFieldswith a Windows backslash catalog path and the fixture's mixed-separator journal value returnsnull(refused). Withpath.win32.joinon both sides it restores.bun test tests/clients/client-disconnect-edited-codex.test.ts: 4 pass, 0 fail.bun run typecheck: exit 0.Checklist
Summary by CodeRabbit