Repository navigation
test(link): import the retirement module by file path in subprocess cases - #8692
Conversation
|
✅ Deterministic PR hygiene checks passed. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Maintainer judgment (dev integration, MAINTAINERS.md maintainer-integration exception): merging without a second maintainer approval, as part of the DEV-RED repair for dev batch run 43413601225 (windows 3/14).
|
Summary
windows 3/14 of dev batch run 43413601225 failed
tests/clients/link-retirement.test.ts:27"receipt survives a fresh process and is private" (JSON Parse error: Unexpected EOF) and:39"competing processes cannot both claim the same link". These cases came with #8416 (f23910ab2d). They build the module path for abun -echild withnew URL(...).pathname. That gives/D:/a/...for a Windows file URL and keeps percent escapes (for example%20for a space), so the child cannot import the module and prints nothing.Both cases now use
fileURLToPath. Assertions are unchanged; test-only.Verification
Unexpected EOF. After: 8 pass, 0 fail.bun test tests/clients/link-retirement.test.ts: 8 pass, 0 fail.bun run typecheck: exit 0.Checklist
Summary by CodeRabbit