Skip to content

test(update): align the Windows restart entry of the update import inventory - #8673

Merged
lidge-jun merged 1 commit into
devfrom
fix/dev-red2-pnpm-update-windows-b
Nov 13, 2026
Merged

lidge-jun merged 1 commit into
devfrom
fix/dev-red2-pnpm-update-windows-b

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

windows 9/14 of dev batch run 43369456647 failed tests/update/update-mutation-guard.test.ts "known-pattern lint finds no unclassified update primitive references" and "known-pattern helper inventory has explicit control-site contracts". #8573 (d1f36eda24) changed src/update/job-windows-restart.ts to import only guardedStopWindowsChecked, but the inventory in tests/helpers/update-import-policy.ts still listed the old guardedStopWinsw and readServiceBackend imports. The lint runs only where its TypeScript parser starts, so the Linux shards did not catch it.

The inventory entry now matches the file's actual imports. The control-site contracts stay enforced. Test-only.

Verification

  • Ran the scanner on Linux with TypeScript's parser under Node: before, it reported the three violations seen on Windows; after, zero violations and all 167 control sites matched.
  • bun run test:changed: 2 pass, 304 skip (the parser-based cases cannot start under Bun on POSIX), 0 fail. bun run typecheck: exit 0.
  • NOT RUN: a native Windows runner (next dev batch), and the full suite.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Tests
    • Updated checks for permitted imports in the restart job.
    • No user-facing behavior changed.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 13, 2026 07:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T07:57:37.518645Z 28cbff5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Nov 13, 2026
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The static-import policy for the Windows restart entry removes two expected imports and retains guardedStopWindowsChecked.

Changes: Windows restart import policy

Layer / File(s) Summary
Update Windows restart import expectations
tests/helpers/update-import-policy.ts
The policy no longer expects guardedStopWinsw or readServiceBackend for src/update/job-windows-restart.ts. It still expects guardedStopWindowsChecked.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

  • lidge-jun/opencodex#8573: This PR adds the checked Windows stop to the updater path, which the import policy in this PR reflects.

Suggested reviewers: luvs01

Merge Risk: Minimal · up to 28cbf

This change only updates a test helper so the expected imports for the Windows restart entry match the source. It has no production impact, and no merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the test-only change to the Windows restart entry of the update import inventory, which matches the raw summary (the static-import policy for src/update/job-windows-restart.ts drops gu…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the test-only change to the Windows restart entry of the update import inventory, which matches the raw summary (the static-import policy for src/update/job-windows-restart.ts drops guardedStopWinsw and readServiceBackend) and the PR objectives (aligning the entry in tests/helpers/update-import-policy.ts with the current imports). It is specific, follows the conventional type(scope) form, and a teammate scanning history would understand the main change. Minor point: 'align' is slightly abstract, but it is not vague enough to be inconclusive.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 3762722 and 28cbff5.

Files selected for processing: 1

  • tests/helpers/update-import-policy.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer judgment (dev integration, MAINTAINERS.md maintainer-integration exception): merging without a second maintainer approval, as part of the DEV-RED repair for dev batch run 43369456647 (windows 9/14).

  • Exact head: 28cbff527c5d94242d6f9e62c35817b5c7167b75. Every required PR check on this head passed.
  • Fresh independent review on this exact head (gpt-6.1-terra, high): VERDICT: PASS, no findings. Its Node-parser run of the scanner: 0 violations, 167 of 167 control sites matched; typecheck, structure:check and privacy:scan exit 0.
  • Classification: stale inventory entry after feat(service): wire the checked Windows stop into every stop path (#7771 slice 2) #8573 changed the imports of src/update/job-windows-restart.ts. Test-only; the control-site contracts stay enforced.
  • No outstanding change requests.

@lidge-jun
lidge-jun merged commit 1281d36 into dev Nov 13, 2026
31 checks passed
@lidge-jun
lidge-jun deleted the fix/dev-red2-pnpm-update-windows-b branch November 13, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant