Repository navigation
test(update): align the Windows restart entry of the update import inventory - #8673
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Maintainer judgment (dev integration, MAINTAINERS.md maintainer-integration exception): merging without a second maintainer approval, as part of the DEV-RED repair for dev batch run 43369456647 (windows 9/14).
|
Summary
windows 9/14 of dev batch run 43369456647 failed
tests/update/update-mutation-guard.test.ts"known-pattern lint finds no unclassified update primitive references" and "known-pattern helper inventory has explicit control-site contracts". #8573 (d1f36eda24) changedsrc/update/job-windows-restart.tsto import onlyguardedStopWindowsChecked, but the inventory intests/helpers/update-import-policy.tsstill listed the oldguardedStopWinswandreadServiceBackendimports. The lint runs only where its TypeScript parser starts, so the Linux shards did not catch it.The inventory entry now matches the file's actual imports. The control-site contracts stay enforced. Test-only.
Verification
bun run test:changed: 2 pass, 304 skip (the parser-based cases cannot start under Bun on POSIX), 0 fail.bun run typecheck: exit 0.Checklist
Summary by CodeRabbit