Skip to content

test(responses): select the inspection tee in its stalled-reader cases - #8671

Merged
lidge-jun merged 1 commit into
devfrom
fix/dev-red2-link-windows-c
Nov 13, 2026
Merged

lidge-jun merged 1 commit into
devfrom
fix/dev-red2-link-windows-c

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

windows 6/14 of dev batch run 43369456647 failed tests/responses/stalled-reader-memory.test.ts:72 and :79, "upstream read-ahead under a stalled reader (#8601) > a link turn with the feature off keeps the inspection read-ahead" and "a local request keeps the inspection read-ahead and its bytes". They expected at least 32 pulls and saw 9. #8622 (f4386e79a5) made Windows select the eager relay, whose queue is 8 MiB, instead of the inspection tee with its 32 MiB read-ahead. These cases measure the tee but ran on the host's platform.

They now select the tee explicitly (setRelayPlatformForTests("linux"), reset after each case). The Windows eager relay and its 8 MiB bound keep their own cases in the same file, and the byte-for-byte delivery assertions are unchanged. Open #8647 adds different cases to this file and does not fix these. Test-only.

Verification

  • With the relay platform reported as Windows on Linux: on dev, "a local request keeps the inspection read-ahead" fails (expected at least 32 pulls, received 9); with this change the file passes 9/9.
  • bun test tests/responses/stalled-reader-memory.test.ts: 9 pass, 0 fail. bun run typecheck: exit 0.
  • NOT RUN: a native Windows runner (next dev batch), and the full suite.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 13, 2026 07:36
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between e0fc3f0 and 2b968da.

Files selected for processing: 1

  • tests/responses/stalled-reader-memory.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T07:38:09.754544Z 2b968da PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Nov 13, 2026
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer judgment (dev integration, MAINTAINERS.md maintainer-integration exception): merging without a second maintainer approval, as part of the DEV-RED repair for dev batch run 43369456647 (windows 6/14).

@lidge-jun
lidge-jun merged commit 33a8e08 into dev Nov 13, 2026
27 checks passed
@lidge-jun
lidge-jun deleted the fix/dev-red2-link-windows-c branch November 13, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant