Repository navigation
test(responses): select the inspection tee in its stalled-reader cases - #8671
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Maintainer judgment (dev integration, MAINTAINERS.md maintainer-integration exception): merging without a second maintainer approval, as part of the DEV-RED repair for dev batch run 43369456647 (windows 6/14).
|
Summary
windows 6/14 of dev batch run 43369456647 failed
tests/responses/stalled-reader-memory.test.ts:72and:79, "upstream read-ahead under a stalled reader (#8601) > a link turn with the feature off keeps the inspection read-ahead" and "a local request keeps the inspection read-ahead and its bytes". They expected at least 32 pulls and saw 9. #8622 (f4386e79a5) made Windows select the eager relay, whose queue is 8 MiB, instead of the inspection tee with its 32 MiB read-ahead. These cases measure the tee but ran on the host's platform.They now select the tee explicitly (
setRelayPlatformForTests("linux"), reset after each case). The Windows eager relay and its 8 MiB bound keep their own cases in the same file, and the byte-for-byte delivery assertions are unchanged. Open #8647 adds different cases to this file and does not fix these. Test-only.Verification
bun test tests/responses/stalled-reader-memory.test.ts: 9 pass, 0 fail.bun run typecheck: exit 0.Checklist