Skip to content

test(uninstall): supply Windows restart proof in cleanup fixtures - #8665

Merged
lidge-jun merged 1 commit into
devfrom
fix/dev-red2-uninstall-windows
Nov 13, 2026
Merged

lidge-jun merged 1 commit into
devfrom
fix/dev-red2-uninstall-windows

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

Dev batch run 43369456647 failed on Windows in two uninstall groups:

The cause is #8573 (d1f36eda24, "wire the checked Windows stop into every stop path"). On Windows, a clean service stop now owes a verified restart window (sharedTeardownAuthorized in src/cli/uninstall-plan.ts). These fixtures still described a completed stop with respawnWindowVerified: false, so the gate correctly refused shared teardown before the tests reached their own assertions. That made them fail on Windows only.

The three fixtures now describe a completed stop with proof (respawnWindowVerified: true). Product behavior and assertions are unchanged. The refusal itself stays covered: uninstall gates shared teardown on a proven service stop still asserts that Windows refuses teardown without the proof. Open #8556 addresses a separate ownership-lock race and does not touch these fixtures.

Verification

  • Windows reproduced on Linux with a win32 platform preload: before, the filtered uninstall case and the ownership-rerun case each fail (0 pass, 1 fail) with the CI's teardown-refusal message. After, with Windows injected at the teardown gate, the cleanup and integration cases pass 37/0 and the rerun cases 2/0.
  • bun test tests/cli/uninstall.test.ts tests/config/config-ownership-concurrent-record.test.ts: 130 pass, 0 fail.
  • bun run typecheck: exit 0. bun run test:changed: 130 pass, 0 fail.
  • NOT RUN: a native Windows runner (the maintainer's next dev batch covers it), and the full suite.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Tests
    • Updated uninstall and configuration-cleanup test scenarios to use a verified respawn window. No end-user behavior changes.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 13, 2026 06:48
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T06:50:24.901102Z 7f77e7b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Nov 13, 2026
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Three test inputs now set respawnWindowVerified to true: one in the uninstall teardown fixture and two in config cleanup tests.

Changes: Respawn verification test fixtures

Layer / File(s) Summary
Update verified respawn inputs
tests/cli/uninstall.test.ts, tests/config/config-ownership-concurrent-record.test.ts
The safeTeardown fixture at line 483 and the cleanup test inputs at lines 490 and 571 now set respawnWindowVerified to true.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: luvs01

Merge Risk: Minimal · up to 7f77e

This only updates test fixtures so the uninstall cleanup tests reach their assertions again. Product behavior is unchanged, and there is no identified merge risk.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "test(uninstall): supply Windows restart proof in cleanup fixtures" matches the change. The raw summary shows the test fixtures in tests/cli/uninstall.test.ts and tests/config/config-ownersh…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "test(uninstall): supply Windows restart proof in cleanup fixtures" matches the change. The raw summary shows the test fixtures in tests/cli/uninstall.test.ts and tests/config/config-ownership-concurrent-record.test.ts switching respawnWindowVerified from false to true. The PR objectives describe the same intent, which is to mark a completed Windows service stop as restart-window verified in three uninstall test fixtures. The title names the main change, the scope (uninstall tests), and the reason (Windows restart proof). It is a single line and avoids vague terms.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f23910a and 7f77e7b.

Files selected for processing: 2

  • tests/cli/uninstall.test.ts
  • tests/config/config-ownership-concurrent-record.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer judgment (dev integration, MAINTAINERS.md maintainer-integration exception): merging without a second maintainer approval, as part of the DEV-RED repair for dev batch run 43369456647 (windows 3/14 and 7/14).

  • Exact head: 7f77e7bed3d646e127dc712fa09cdd6c2b90e9a1. Every required PR check on this head passed.
  • Fresh independent review on this exact head (gpt-6.1-terra, high): VERDICT: PASS, no findings. Its fresh runs: uninstall and config-ownership 130 pass / 0 fail; typecheck exit 0; a direct sharedTeardownAuthorized check confirms the old fixture value was refused on Windows only.
  • Classification: test-assumption regression from feat(service): wire the checked Windows stop into every stop path (#7771 slice 2) #8573 (d1f36ed); fixture-only, and the Windows refusal assertion remains.
  • No outstanding change requests.
  • Not yet verified on a native Windows runner; the maintainer's next dev batch covers it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant