Repository navigation
test(uninstall): supply Windows restart proof in cleanup fixtures - #8665
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Maintainer judgment (dev integration, MAINTAINERS.md maintainer-integration exception): merging without a second maintainer approval, as part of the DEV-RED repair for dev batch run 43369456647 (windows 3/14 and 7/14).
|
Summary
Dev batch run 43369456647 failed on Windows in two uninstall groups:
tests/cli/uninstall.test.ts"uninstall client cleanup before owner-state deletion" (cleanup exception propagation, picker trust retirement, pending ACL reap and others).tests/config/config-ownership-concurrent-record.test.ts"rerunning ocx uninstall through its cleanup flow (Uninstall manifest can lose recorded paths when two processes call recordOwnedConfigPath #8093)" and "rerun after the owner marker was already deleted (Uninstall manifest can lose recorded paths when two processes call recordOwnedConfigPath #8093)".The cause is #8573 (
d1f36eda24, "wire the checked Windows stop into every stop path"). On Windows, a clean service stop now owes a verified restart window (sharedTeardownAuthorizedinsrc/cli/uninstall-plan.ts). These fixtures still described a completed stop withrespawnWindowVerified: false, so the gate correctly refused shared teardown before the tests reached their own assertions. That made them fail on Windows only.The three fixtures now describe a completed stop with proof (
respawnWindowVerified: true). Product behavior and assertions are unchanged. The refusal itself stays covered:uninstall gates shared teardown on a proven service stopstill asserts that Windows refuses teardown without the proof. Open #8556 addresses a separate ownership-lock race and does not touch these fixtures.Verification
bun test tests/cli/uninstall.test.ts tests/config/config-ownership-concurrent-record.test.ts: 130 pass, 0 fail.bun run typecheck: exit 0.bun run test:changed: 130 pass, 0 fail.Checklist
Summary by CodeRabbit