Repository navigation
fix(antigravity): let max and ultra select Hydrogen's xhigh tier and record its CCA verification - #8644
Merged
lidge-jun merged 5 commits intoNov 13, 2026
Conversation
…record its CCA verification On a discovered family that has an xhigh tier, requested max and ultra now select it instead of clamping to high; three-tier families are unchanged. Comments and docs that called Hydrogen on CCA unobserved now record the 2026-11-12 check: an entitled account's CCA discovery listed the four tiers and gemini-4-hydrogen-xhigh answered 200 under the CLI User-Agent.
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Contributor
✅ READY
Review readiness checklist
✅ 4/4 boxes ticked. This pull request has been marked Ready for Review. Hygiene✅ Deterministic PR hygiene checks passed. |
…d a restored snapshot
Owner
Maintainer judgmentMerging at head
|
github-actions
Bot
requested review from
Ingwannu and
lidge-jun
as code owners
November 13, 2026 06:02
lidge-jun
added a commit
that referenced
this pull request
Nov 13, 2026
Brings in dev through 6f58f62, including #8612 (recover a force-revoked ephemeral Child by its link id: tombstones, ocx link recover), #8635 and #8644. Conflict resolution in removeReserved keeps both sides: dev's tombstone is written before the first intent for a forced revoke of an ephemeral Child, with this PR's cleanup condition (cleanup already recorded by the owner's journal is not rerun); every way out that does not commit (claim failure, a changed record, a failed key revoke or journal intent, the post-commit catch) drops the force's own tombstone, which dev's helper does only while the link still exists; a committed non-force removal settles earlier tombstones of the link. remove() admits the alias lock for a tombstoned alias using the removal target's record. The generated skill surface was regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #8636, which folded Gemini 4 Hydrogen's discovered
-xhightier into its family. Two gaps remain, both small:maxandultrastill clamp tohighon a four-tier family.discoveredAntigravityEffortWireModelIdselects the xhigh tier only for the literalxhigh;maxandultrago throughresolveAntigravityThinkingLeveland land ongemini-4-hydrogen-high. A client that asks for its top effort under either name therefore gets one rung below what the family offers. This PR makesxhigh,maxandultrashare one set (ANTIGRAVITY_ABOVE_HIGH_EFFORTS): they select a discovered xhigh tier when the family has one, and clamp tohighexactly as before when it does not. Argon, Carbon and every other three-tier family are unchanged, and the existing three-tier test now asserts that for all three efforts.gemini-4-hydrogen-low/-medium/-high/-xhigh, and an xhigh request through this proxy answered 200 (details under Verification). The comments insrc/adapters/google-antigravity-wire.tsandsrc/providers/antigravity-models.ts, the Hydrogen test header,structure/providers-and-adapters.mdand the English providers guide now say so. The guide also notes thatmax/ultraselect xhigh.No change to discovery, the snapshot format, the User-Agent rule, the Hydrogen
highdefault, or partial-family handling.Verification
Failing first. The test commit (
test(antigravity): pin max and ultra ...) extendstests/adapters/google/gemini-4-hydrogen-antigravity.test.ts. The same resolution run against thedevsource and against this branch:Local checks on this branch (based on
devat61dfb8be4):bun run typecheck: exit 0, "No type errors in 2,492 files".bun run structure:check: exit 0, "structure/ SSOT checks passed".bun run privacy:scan: exit 0, "Privacy scan passed".bun test tests/adapters/google/gemini-4-hydrogen-antigravity.test.ts tests/adapters/google/antigravity-discovered-families.test.ts tests/adapters/google/gemini-4-argon-antigravity.test.ts tests/providers/provider-antigravity-effort-families.test.ts tests/providers/provider-antigravity-wire-snapshot.test.ts tests/providers/provider-antigravity-family-catalog.test.ts tests/adapters/google/google-antigravity-wire.test.ts tests/ci-workflows/repo-hygiene.test.ts: exit 0, 144 pass, 0 fail across 8 files. The existing three-tier tests (Argonxhigh→-high, partial families keep their wire identity) are unchanged and pass.Resource exception:
bun run test:changedand the fullbun run testwere not completed. Several worktrees on this machine were running suites at once and share the user-scoped test-run lock; thetest:changedattempt waited 807 s for the lock and was then terminated by the 900 s suite limit (exit 124) with 70 failures, none in an Antigravity, Google or catalog test file, most of them 5 s timeouts. That run was on the earlier, larger version of this change before rebasing. Import-graph coverage beyond the files listed above is left to CI.Live check against Cloud Code Assist (2026-11-12, local test port, temporary
OPENCODEX_HOMEholding one Antigravity account and only thegoogle-antigravityprovider, deleted afterwards; the build was this change's earlier version, whose xhigh routing matchesdevplus this PR):GET /v1/models, i.e. one discovery:google-antigravity/gemini-4-hydrogenappeared once with effortslow,medium,high,xhigh, and no separategemini-4-hydrogen-xhighrow. The saved wire snapshot recordedxhigh: "gemini-4-hydrogen-xhigh"from CCA's own listing.POST /v1/responses,model: google-antigravity/gemini-4-hydrogen,reasoning.effort: xhigh: HTTP 200,status: completed, 25 reasoning tokens.xhighandmaxproducedmodel: gemini-4-hydrogen-xhighwith the CLI User-Agent andthinkingConfig: {includeThoughts: true}(nothinkingLevel);highproducedgemini-4-hydrogen-high.Checklist
Maintainer follow-up (head 45fdd2a)
es/guides/providers.md) mirrors the English sentence: Hydrogen's CCA status and themax/ultrarule.antigravity-models.ts(rule 2/3) now says discovery clamps above-high efforts only for a family without an xhigh tier.xhigh/max/ultra/high/no effort, with and without the catalog ladder; routing from a restored persisted snapshot (four-tier Hydrogen selects-xhigh, three-tier Carbon clamps to-high). Againstdev's source, the three xhigh-routing tests fail; with this PR, 9 of 9 pass.dev.bun run typecheck,structure:checkandprivacy:scanpass, and these files pass with 0 failures, one process each: gemini-4-hydrogen-antigravity (9), gemini-4-argon-antigravity (19), antigravity-discovered-families (11), google-antigravity-wire (62), antigravity-routing-carry (28), antigravity-account-roster (14), provider-antigravity-wire-snapshot (6), provider-antigravity-effort-families (19), docs-spanish-localization (30), file-size-ratchet (9), repo-hygiene (16).Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.