Repository navigation
test(sync): expect Pi's server-owned refresh after #8287 - #8606
Conversation
#8287 moved Pi out of the direct ocx sync fan-out: an owned Pi file now refreshes through the serving proxy (refreshPiThroughServer), because only the proxy can prove its raw nested selectors. Two source/dispatch oracles still listed "pi" in the fan-out, so dev went red at 7ce7d5a. Assert the fan-out list without "pi" and that Pi takes the server path, and stub that path in the dispatch test so it never reaches a real port.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Maintainer judgmentReviewed head:
Final-head review ( |
Summary
devhas been red since #8287 (7ce7d5a9). That PR moved Pi out of the directocx syncfan-out: an owned Pi file now refreshes through the serving proxy (refreshPiThroughServerinsrc/cli/pi-sync.ts), because only the proxy can prove Pi's raw nested selectors. Two tests still expected"pi"in the fan-out list:tests/clients/sync-client-integrations.test.ts› "the direct ocx sync command refreshes owned clients including OpenCode and Kilo and server-owned Aside"tests/cli/cli-dispatch.test.ts› "dispatchCommand exit codes > sync refreshes already-owned OpenCode and Kilo after publishing the Codex catalog"This PR updates both tests to match #8287's design. They now expect the fan-out list without
"pi"and check that sync callsrefreshPiThroughServer. The dispatch test also stubs that call, so it never sends a real request to its fake port. Runtime code is unchanged.Verification
Bun 1.4.4 / macOS, isolated
HOME/OPENCODEX_HOME/CODEX_HOME/CLAUDE_CONFIG_DIR.7ce7d5a9,bun test --isolate tests/cli/cli-dispatch.test.ts tests/clients/sync-client-integrations.test.tsgives 117 pass / 2 fail, and the two failures are the cases above. On its parent05d34b94the same command gives 119 pass / 0 fail.bun test --isolate tests/cli/cli-dispatch.test.ts tests/clients/sync-client-integrations.test.ts tests/ci-workflows/file-size-ratchet.test.tsgives 128 pass / 0 fail.bun run typecheck(2,442 files) andbun scripts/file-size-ratchet.ts: passed.bun run testsuite.Checklist
Summary by CodeRabbit