Repository navigation
feat: add opt-in plaintext V2 subagent mode - #7376
Conversation
Select V2 through model catalog pins while enabling the existing plaintext task-message compiler. Require explicit CLI/API/UI acknowledgement, preserve legacy preferences and existing chat history, and verify runtime support and write receipts. Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Scoped intake at |
|
Confirmed against
Hosted CI is now complete with no failed or pending checks; skipped platform jobs remain unverified. These are fixture/unit/DOM-harness results. A fresh native session using catalog-only V2 through a live ChatGPT-to-routed-provider handoff is still unvalidated. The separate V1-to-V2 resume experiment does not establish that handoff contract. Keeping Draft for the owner product/consent and task-retention disposition and the remaining handoff validation. No live activation, history rewrite, or final GUI acceptance is claimed. |
|
Additional bounded native evidence for the catalog selection contract at
The first handoff checker timed out because it expected a nonexistent The parent finished before the child's completed activity arrived, so the parent model consuming the child's final answer was not observed. This was native-to-mock validation, not the OpenCodex compiler path or a real ChatGPT-to-external-provider handoff. The child message retained its native encrypted content; no decryption or live-account operation was involved. Classic tool rows also do not establish |
|
The remaining native/compiler/result-delivery path now passes a bounded integration fixture at Installed Codex
The earlier failed fixtures are preserved: one lacked the explicit local-provider allowance; the next mismatched the adapter's default Still unverified: real ChatGPT acceptance of the alias/plaintext-task contract, a real routed provider, modern code-mode/Responses Lite execution, and final GUI/owner product-consent/task-retention acceptance. This closes the classic native-to-production-compiler-to-mock handoff gap, not the live-provider gap. Keeping Draft; no live activation or history rewrite. |
|
Follow-up intake at |
|
Current-head native validation passed at The fixture rebuilt the production
The component receipt SHA-256 is This refresh closes the current-head native parent/child/tool/result-delivery fixture gap. Real ChatGPT or routed-provider acceptance, WebSocket transport, and arbitrary installed builds remain separate claims. Keeping Draft for the owner's experimental-mode/UI decision and independent plaintext-retention boundary review, as requested; no live activation or history rewrite. |
Distinguish new-session catalog pins from request-time compilation in every registered GUI locale, CLI output and documentation. Cover an existing V2 request before, during and after activation, including retained continuation messages after opt-out. Runtime policy and compiler behavior are unchanged.
|
Current head is Pinned Bun 1.4.3 ran both complete CLI files: 120 passed, with one existing native root-slot translation case exceeding the default 5-second timeout. That case alone passed under a 15-second limit (1 passed, 20 assertions, 7.19 seconds). No assertion failure remained. Exact-head automatic CI is tracked in the PR checks. Production/GUI/docs source is identical to The retention review found that “applies to new sessions” conflated two scopes. Catalog pins affect new sessions; the enabled compiler also processes subsequent eligible canonical ChatGPT requests from existing V2 sessions. All 11 registered GUI locales, CLI and docs now make that distinction and state that disabling does not delete retained copies. Existing ciphertext is not decrypted and stored history is not rewritten; runtime policy is unchanged. The new production-handler regression reuses an existing-V2 request through OFF → ON → OFF, checks the actual outbound declarations and retained continuation content, and uses a strict fetch stub. The current correction passed 65 focused checks plus type/structure/privacy/metadata/ratchet, GUI build and docs build. Four installed-browser headless layout/initial-state cases also passed; current PNGs remain local, unuploaded. The old This resolves the reported disclosure-scope finding, not the separately reserved owner product/UI decision or real ChatGPT/provider acceptance. Earlier native fixtures remain attributed to their original heads; the installed OpenCodex 2.89.0 Devin observation remains separate. Keeping Draft under the owner's disposition. No manual CI, live configuration change, paid native/provider call or Security Cloud scan was performed. |
…7376-dev-26598-7627-20261025
…7376-dev-26598-7627-20261025
|
Owner decision: accepted — the opt-in plaintext V2 subagent mode is approved as a product feature, including the documented retention behavior (disabling it does not delete copies already retained). Remaining before merge: update the branch onto current |
Preserve admitted configuration writes and extracted catalog construction. Co-authored-by: Epinephrine <27862058+luvs01@users.noreply.github.com>
Use the shared mode resolver while preserving retained native priorities. The focused regression fails with the pre-fix resolver and passes after. Co-authored-by: Epinephrine <27862058+luvs01@users.noreply.github.com>
|
Maintainer carry pushed normally to 9216be9.
Independent maintainer security review and successful exact-head hosted CI are still required before merge. No older-head checks are promoted to current-head evidence. NOT RUN: complete root/GUI suites (owner-requested resource exception for parallel Windows lanes; left to CI), current-head native Codex handoff, live ChatGPT/routed-provider acceptance, macOS/Linux runtime proof, full native matrix, manual CI dispatch, independent maintainer security review. |
Authorize direct and combo continuation reads before spill materialization. Preserve owner bindings through snapshots and spills and refuse foreign-id replacement. Add handler and storage regressions and migrate replay fixtures to real configured admission without weakening their behavior assertions. The final shared-state compatibility run retains one unresolved 3000 ms shutdown-child watchdog timeout; the PR remains draft for that validation failure and independent exact-head security acceptance. Co-authored-by: Epinephrine <27862058+luvs01@users.noreply.github.com>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
…t-impl # Conflicts: # tests/fixtures/claude-efficiency-cli.ts
Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
…ompiled plaintext without an owner Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
# Conflicts: # docs-site/src/content/docs/guides/subagent-v1-default.md # docs-site/src/content/docs/ja/reference/configuration/agents.md # docs-site/src/content/docs/ko/guides/subagent-v1-default.md # docs-site/src/content/docs/ko/reference/configuration/agents.md # docs-site/src/content/docs/ru/reference/configuration/agents.md # docs-site/src/content/docs/tr/guides/subagent-v1-default.md # docs-site/src/content/docs/tr/reference/configuration/agents.md # docs-site/src/content/docs/zh-cn/guides/subagent-v1-default.md # docs-site/src/content/docs/zh-cn/reference/configuration/agents.md # docs-site/src/content/docs/zh-tw/guides/subagent-v1-default.md # docs-site/src/content/docs/zh-tw/reference/configuration/agents.md
Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: Epinephrine <luvs01@hanmail.net>
Maintainer judgment — merge of #7376 at
|
Summary
Add the explicit experimental
v2-plaintextsubagent mode: V2 catalog pins with the global override off, canonical ChatGPT task compilation, and plaintext-retention acknowledgment at GUI/CLI/API entry. Default-off behavior and the independent legacy flag remain unchanged. Catalog pins affect new chats; enabled compilation also applies to subsequent eligible canonical ChatGPT requests from existing V2 chats. Existing ciphertext is not decrypted, and disabling the mode does not delete retained copies.config setandconfig importcannot newly enter plaintext mode. They direct the operator toocx v2 mode v2-plaintext --acknowledge-plaintext-agent-messages, which also coordinates the native transition. Already-active restoration, unrelated settings, exits and the independent legacy preference remain supported.The dev redesign moves the dashboard mode switch into the settings row. Its existing capability/consent path is preserved there and in the Subagents panel, including the enabled-plaintext hint. WebSocket upgrade data carries both dev's observational client classification (fifth argument) and the admitted replay principal (sixth); client classification cannot grant replay authority.
The owner accepted the feature and its retention behavior. Current head is
e6d38eb1df6b6048bf820e99994e06bd3288aa19, merged with devaa30ea9d5ewithout rewriting author history.Verification
The previous hosted
test 2/5failure was reproduced locally: the newly merged chained-reset fixture called the raw handler without a replay owner, so the next request returned 429 instead of 200. The fixture now uses the existing admitted-owner helper. Its upstream refusal assertions remain intact.The
state.tsmerge keeps owner authorization before spill materialization and preserves upstream's distinction between client-carried and proxy-restored history. A new regression covers that distinction and its propagation to an internal body clone.Bun 1.4.4 validation:
bun check --no-script --noEmit: passed, 2,437 files.bun run structure:checkandgit diff --check: passed.Full local/GUI suites were not repeated because shared Windows storage was under heavy contention; current-head hosted CI supplies broader coverage and passed. No native app acceptance or security-review approval is inferred from these tests.
Hosted-CI follow-up
e6d38eb1dfbinds the newly merged eager-catalog HTTP/WS fixtures to the same admitted principal and own thread as their stored replay. It also waits for the synthetic Claude CLI stdout result write before exiting, preventing large JSON replies from being truncated by pipe buffering. Production behavior is unchanged by this follow-up.claude-cli-client-http.test.tscases passed locally after the stdout fix.--timeout 30000after measured Windows startup exceeded the default 5-second hook budget; no committed test timeout changed.git diff --checkpassed. Current-head hosted CI passed: https://github.com/lidge-jun/opencodex/actions/runs/43185802386 (all five test shards and gates).UI evidence
No visual change in this follow-up. Existing plaintext-mode UI evidence:
Final head
13f788ed69152e8cb0348da5550be2636a2412e9(maintainer integration)previous_response_idcontinuation. Replay scoping is now decided byisPlaintextV2AgentMessagesEnabled(config)(modev2-plaintextor the legacyplaintextV2AgentMessagesflag): strict principal + ownthread-idbinding while plaintext is enabled,dev's parent-thread scope otherwise; state bound while plaintext was on stays bound.devbehaviour; synced English and all eight locales (incl. new Spanish) for the mode roster, enablement paths, consent, config restore, replay identity, Ultra eligibility, same-target status checks and catalog-pin vs compiler scope.test 3/5passed on rerun after a client-link orphan-liveness flake that also passes locally on this head and ondev). Independent security review PASS (no PR-owned src/gui change since it); final technical review PASS (608 focused tests, typecheck, structure, docs build). Union with currentdevchecked locally: replay ownership 40/0, eager catalog 38/0, layout and Lab boundary green, typecheck green; the only docs failure istroubleshooting/update-failed.mdSpanish parity, which also fails ondevitself (from fix(update): verify pnpm global-store installs against the store pnpm names #8331) and is being fixed separately.Checklist