Desktop: Fixes #16099: Skip the note lock session effect on the first render - #16100
Merged
laurent22 merged 2 commits intoJul 31, 2026
Merged
Conversation
mrjo118
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16099
The session change effect in useFormNote checks the previous value against
undefined, but usePrevious starts its ref atnull, so it never skips the first render and refreshes the note on mount. Seeding usePrevious with the current value makes the first render compare equal, and theundefinedcheck goes with it since there's no sentinel left to guard against. Real session changes still refresh as before.The test also waits for its own setup save to flush, so that change event can't reach the hook's listener and reload the note mid-test.
Ran
yarn tscand the app-desktop suite. Note.load calls on mount went from 4 to 2 with note lock on and an editor plugin active.I used AI tools on this PR for code suggestions and review, and reviewed and tested the changes myself.