⬆️ chore: update dependencies - #741
Merged
Merged
Conversation
Bumps @types/react-dom, autoprefixer, postcss, lucide-react, vitest and @vitest/coverage-v8 to their latest releases. Retries the packages held back in .ncurc.json: @vitejs/plugin-react now passes lint, types, tests and build on 6.1.1, so it leaves the reject list. The remaining three stay rejected: - @tanstack/react-table 9.2.4 rewrites the generics around TableFeatures and drops ColumnDef flags such as enableSorting, producing 60 type errors across VirtualizedTable. - eslint 10.10.0 has no compatible eslint-plugin-react release (latest 7.37.5 peers on eslint <= 9). - typescript 7.0.2 type-checks cleanly but typescript-eslint refuses to load against the TS 7 API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Routine dependency refresh via
npm run deps:update, plus a retry of every package currently held back in.ncurc.json.Updated
@types/react-domautoprefixerpostcsslucide-reactvitest@vitest/coverage-v8@vitejs/plugin-react@vitejs/plugin-reactleaves the reject list: 6.1.1 passes lint, types, tests and build, so there is no longer a reason to hold it back.Still rejected
Each was installed and verified individually before being reverted:
@tanstack/react-table9.2.4 — 60 type errors. v9 reshapes the generics aroundTableFeatures(now the leading type parameter) and dropsColumnDefflags such asenableSorting.VirtualizedTable.types.ts,contexts/table.types.tsand the stories all break. This is a migration, not an adjustment.eslint10.10.0 — no compatibleeslint-plugin-reactrelease exists; 7.37.5 is the latest and peers oneslint <= 9.7. ESLint 10 also stops exposing@eslint/jsandglobalstransitively, soeslint.config.jswould need them added as explicit devDependencies.typescript7.0.2 —tsctype-checks cleanly, buttypescript-eslintrefuses to load against the TS 7 API (tracked in typescript-eslint#10940). The only way through is a side-by-side TS 6 install under an alias, which is the kind of pinning workaround the project avoids.Notes
peerDependenciesneeded no changes — none of the bumped packages appear there (@types/react-domis ranged*).rm -rf node_modules package-lock.json) so the@emnapi/*entries survive, and verified withnpm cionnode:24/linux/amd64in Docker.Verification
npm run lint— passnpm run check:types— passnpm run ci— prettier, 856 tests across 56 files, build — passnpm cion Linux via Docker — passOne caveat on the test suite:
DateRangePicker.test.tsx:1046asserts a 7-day window equals6 * DAY_MS, which is false in any timezone that crosses a DST boundary inside that window. It fails locally inAmerica/Santiago(DST started 6 Sep) and passes in UTC, so CI is unaffected. Pre-existing and unrelated to this change; happy to fix it separately.