Conversation
The multi-select counterpart of RadioCard: a clickable card with a title, a description and a checkbox that reflects the checked state on its border. Settings built it as EventCheckboxCard for webhook events, with a `key` remount hack to sync an uncontrolled Checkbox; CheckboxCard works controlled and uncontrolled and names the checkbox after the title only, describing it with the secondary text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New
CheckboxCard, the multi-select counterpart ofRadioCard: a clickable card with a title, an optional description and aCheckbox, reflecting the checked state on the card border. Settings built this asEventCheckboxCardfor webhook events (with akeyremount hack to sync an uncontrolledCheckbox).checked) and uncontrolled (defaultChecked).aria-labelledby) and described by the secondary text (aria-describedby), so screen readers do not hear the description as part of the name.disabledblocks toggling and dims the card.Test plan
npx vitest run lib/components/CheckboxCard lib/components/Checkbox, lint, types, prettierCheckboxCard