Conversation
Long paths (object storage folders, nested resources) overflow the breadcrumb. `maxVisibleItems` keeps the first and the last steps visible and collapses the middle ones into an ellipsis menu built on Radix DropdownMenu, so the hidden steps stay reachable by keyboard and screen readers; objectstore's FolderBreadcrumb reproduced this with a CSS hover-only menu. `collapsedLabel` names the ellipsis button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Long paths (object storage folders, nested resources) overflow the breadcrumb. Objectstore's
FolderBreadcrumbreproduced a collapsed breadcrumb with a CSS hover-only menu that keyboard users cannot reach.maxVisibleItems: when there are more steps than this, the first and the last ones stay visible and the middle steps collapse into an ellipsis menu (Radix DropdownMenu, keyboard navigable). Hidden steps keep theirto,targetandcomponent, and respect react-router when present.collapsedLabel: accessible name of the ellipsis button (default "Show hidden steps").Without
maxVisibleItemsnothing changes.Test plan
npx vitest run lib/components/Breadcrumb(14), lint, types, prettierBreadcrumb/LightandDark→Collapsed