Conversation
…tate `Tabs.Trigger` no longer requires `isActive`: when omitted, the active styles come from Radix's `data-state` through a named group, so consumers stop mirroring the active value into every trigger (compute detail Tabs, kubernetes cpu/gpu Tabs, settings and billing pages all did this). `items` renders the list, triggers and contents from an array. It is uncontrolled by default, starts on the first item and falls back to it when the active item disappears, which compute's SizeTabs and kubernetes' node pool Tabs implemented locally with useState + useEffect. Passing `value` keeps the tabs controlled as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tabs.TriggerwithoutisActive: when omitted, the active styles are derived from Radix'sdata-statethrough a named group, so consumers stop mirroring the active value into every trigger. Compute (detailTabs), kubernetes (cpu/gpuTabs), settings and billing pages all repeatisActive={activeTab === tab}. PassingisActivestill works.items: declarative API that renders the list, triggers and contents from an array (value,label,content, optional class names,listClassName). Uncontrolled by default: starts on the first item (ordefaultValue) and falls back to the first item when the active one disappears, which computeSizeTabsand kubernetes node poolTabsimplemented locally withuseState+useEffect. Passingvaluekeeps the tabs controlled.Existing children-based usage is unchanged.
Test plan
onValueChange,defaultValue, fallback when the active item disappears, controlledvalue, axenpx vitest run lib/components/Tabs, lint, types, prettierTabs/LightandDark→DeclarativeItems