Add vault payment MCP tools - #182
Open
hiroTamada wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
hiroTamada
marked this pull request as ready for review
September 5, 2026 01:20
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0be41fc. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Expose payment-vault preparation and observation through the existing MCP server using the published TypeScript SDK v0.100.0. These tools do not submit merchant payments or complete provider approvals.
manage_vaults,manage_vault_wallets,manage_vault_cards, andmanage_vault_itemsunder one configurablevaultstoolset, with existing authentication and project-scope enforcement.docs/vault-payments.md.Validation
bun test: 383 passed, 0 failed. Includes MCP discovery/call tests with the real SDK and synthetic HTTP responses, plus input validation, project isolation, no-retry failures, safe output, and browser attachment tests.tools/listschemas without$refs and rejectswaitoutsideget/eventsbefore making an API request.bunx tsc --noEmit: passed.git diff main...HEAD --check: passed. Reviewed the complete diff and removed redundant validation.bun run format:check: blocked only by the unchangedAGENTS.mdformatting warning.bun run build: compilation and TypeScript stages passed; page-data collection stopped becauseKERNEL_CLI_PROD_CLIENT_IDis not configured locally.No live payment credentials were created, no merchant payments were submitted, and no end-to-end provider payment flow was run.
Note
High Risk
Introduces payment-vault credential workflows (wallets, cards, browser aliases) with new external API surface; mistakes in projection, retries, or operation gating could leak secrets or encourage unsafe payment replay despite safeguards.
Overview
Adds a
vaultsMCP toolset (fourmanage_vault_*tools) on@onkernel/sdkv0.100.0, wired through existing auth, project scope, andKERNEL_MCP_ENABLED/DISABLED_TOOLSETS. The tools prepare and observe Link/AgentCard wallets and cards—they do not submit merchant payments.manage_vaultshandles vault CRUD with paginated list and idempotent delete on 404.manage_vault_walletsandmanage_vault_cardsupsert/update items with strict providerspecschemas (no raw card/OAuth fields).manage_vault_itemslists, gets with optionalwait/expand, invokes only API-advertised operations (fresh GET before invoke), streams events with cursors, and deletes items. Sharedvault-responsesprojection strips secrets, unsafe URLs, and opaque provider payloads; errors avoid dumping full API bodies. Vault SDK calls usemaxRetries: 0and propagate cancellation; bounded waits add timeout headroom.manage_browserscreategains optionalvaults(up to 20 id/name refs, creation-only, no retries when bound).docs/vault-payments.mdand README document flows and toolset toggles. Tests cover registration, validation, no-retry behavior, safe output, browser attachment, and analytics redaction for vault tool payloads.Reviewed by Cursor Bugbot for commit ee4a7a0. Bugbot is set up for automated code reviews on this repo. Configure here.