Wait for streaming responses to drain - #369
Draft
tnsardesai wants to merge 1 commit into
Draft
Conversation
tnsardesai
force-pushed
the
hypeship/guest-drain-hold
branch
from
September 4, 2026 23:34
679f63d to
831acb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
Large streaming handlers can return while response bytes remain unacknowledged in the guest TCP send queue. Releasing the request scale-to-zero hold at that point can suspend the guest before the peer receives the response tail.
change
TIOCOUTQevery 100 ms within the same overall deadlineTIOCOUTQsupport and its unsent-plus-unacknowledged semantics were validated in the current browser runtime.tests
go build ./...go vet ./...go test -race ./lib/scaletozero ./cmd/api/apigo test -race $(go list ./... | grep -v '/e2e$')