Preserve API failures across resource delete commands - #246
Closed
rgarcia wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop treating HTTP 404 responses as successful deletion. A 404 can mean that the selected project is invalid, not just that a resource is already absent. Preserve the API's error code and message through the standard CLI error formatter and return a nonzero exit status.
Compatibility
Actual missing-resource 404s now also return an error rather than exit successfully. Successful API responses and cancelled confirmations retain their existing behavior. This intentionally does not distinguish project and resource 404s by parsing error messages.
No SDK/dependency changes. Non-delete 404 handling is unchanged.
Verification
make testpassed (go vet ./...andgo test ./...).make buildpassed.go test -race ./cmd ./cmd/proxies -run 'Test.*Delete' -count=1passed.make lint: 66 existing findings. Directgolangci-lint run --new-from-rev=origin/main: 0 issues.