Add "regionRef" to Endpoint resource - #873
Conversation
b4e0b2c to
019343e
Compare
| # We expect the deletion to hang due to the finalizer, so use --wait=false | ||
| - command: kubectl delete service.openstack.k-orc.cloud endpoint-dependency --wait=false | ||
| namespaced: true | ||
| - command: kubectl delete region.openstack.k-orc.cloud endpoint-dependency --wait=false |
There was a problem hiding this comment.
The tests fail with:
case.go:335: failed to get referenced resource 'kuttl-sensible-bat-h57l/endpoint-dependency': regions.openstack.k-orc.cloud "endpoint-dependency" not found
I'm not exactly sure why... Because it was apparently created successfully in the previous step.
There was a problem hiding this comment.
From what I can see, the region is being created and indeed being deleted, not hanging waiting for a finalizer. I think this is a consequence of using FetchDependency which doesn't add the finalizer to the resource unlike the GetDependency. Suggested that.
| return nil, false | ||
| } | ||
|
|
||
| region, _ := dependency.FetchDependency[*orcv1alpha1.Region]( |
There was a problem hiding this comment.
Change to regionDependency.GetDependency so we add the finalizer to the resource in case of adoption.
There was a problem hiding this comment.
Changed it to GetDependency with nil guard and oddly the flamingo e2e test is now reliably crashing apparently 👀
There was a problem hiding this comment.
From the devstack-logs/g-api.log:
ERROR glance.async_.flows._internal_plugins.web_download [-] Task ... failed with exception
<urlopen error [Errno 101] Network is unreachable>
This looks like a transient issue at github.
There was a problem hiding this comment.
Unfortunately, re-running the job is not going to help. This is an upstream issue caused by openstack/glance@c0f30ec.
We'll need to report the issue to glance.
There was a problem hiding this comment.
This is exactly the problem reported in https://bugs.launchpad.net/glance/+bug/2158999/comments/33.
There was a problem hiding this comment.
We need https://review.opendev.org/c/openstack/glance/+/1004004, but on flamingo 😃
There was a problem hiding this comment.
The glance team is aware of the problem and working on a fix.
There was a problem hiding this comment.
In the meantime, I've dropped the requirement for the flamingo job to unblock us from merging PRs.
| # We expect the deletion to hang due to the finalizer, so use --wait=false | ||
| - command: kubectl delete service.openstack.k-orc.cloud endpoint-dependency --wait=false | ||
| namespaced: true | ||
| - command: kubectl delete region.openstack.k-orc.cloud endpoint-dependency --wait=false |
There was a problem hiding this comment.
From what I can see, the region is being created and indeed being deleted, not hanging waiting for a finalizer. I think this is a consequence of using FetchDependency which doesn't add the finalizer to the resource unlike the GetDependency. Suggested that.
019343e to
370d20f
Compare
github-actions
Bot
added
semver:minor
169b3ca to
45b8eac
Compare
45b8eac to
c636271
Compare
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
Good, I think with that we can also mark the Endpoint controller as complete (✔) in the README.
On-behalf-of: SAP nils.gondermann@sap.com
c636271 to
99b1d15
Compare
|
Is the gazpacho fail also related to the upstream glance thing? Where do I find the |
yes, it has spread out to gazpacho too. |
|
I've merged a workaround to fix the CI jobs. If you rebase, we should be able to merge your patch. |
3 participants
This uses the Region resource implemented in #862 and therefore uses that branch as a base. We would obviously need to merge #862 first.
Other than that I consider this change good to go.