Skip to content

fix: NextJS security upgrade. #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcmartinezdev merged 5 commits into from
Sep 3, 2026
Merged

fix: NextJS security upgrade. #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa0de85
chore: upgrade Next.js and related packages to version 15.5.24
jonathanp-okta Aug 29, 2026
ceb5d21
chore: upgrade to Next.js 16 and ESLint 9
jonathanp-okta Aug 29, 2026
ce3df13
fix: route Vercel builds through Artifactory via OIDC federation, fix CI
jonathanp-okta Aug 29, 2026
1cf6a0b
chore: remove unnecessary permissions and streamline deployment scripts.
jonathanp-okta Sep 1, 2026
e560203
chore: update GitHub Actions workflow for quality checks and add type…
jonathanp-okta Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .eslintrc.json
View file
Open in desktop

This file was deleted.

22 changes: 22 additions & 0 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,28 @@ on:
branches: [master]

jobs:
quality:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '22'

- name: Install dependencies
run: npm ci

- name: Run ESLint
run: npm run lint

- name: Check types
run: npm run typecheck

- name: Build
run: npm run build

test:
runs-on: ubuntu-latest
steps:
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ yarn-error.log*

.npmrc
**/.npmrc
.npmrc.oidc


# Created by https://www.toptal.com/developers/gitignore/api/macos,windows,visualstudiocode,webstorm,intellij,node
Expand Down
16 changes: 16 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import nextCoreWebVitals from "eslint-config-next/core-web-vitals";

const config = [
...nextCoreWebVitals,
{
// Both rules target the Pages Router; this is the App Router root layout,
// which renders <head> itself and loads the font stylesheet per-locale.
files: ["src/features/common/components/layout/page-layout/**"],
rules: {
"@next/next/no-head-element": "off",
"@next/next/no-css-tags": "off",
},
},
];

export default config;
4 changes: 3 additions & 1 deletion next-env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
import "./.next/types/routes.d.ts";
import "./.next/types/root-params.d.ts";

// NOTE: This file should not be edited
// see https://nextjs.org/docs/app/building-your-application/configuring/typescript for more information.
// see https://nextjs.org/docs/app/api-reference/config/typescript for more information.
19 changes: 19 additions & 0 deletions next.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import createMDX from "@next/mdx";

/** @type {import('next').NextConfig} */
const nextConfig = {
// Next 16 writes AGENTS.md/CLAUDE.md on `next dev`; keep them out of the tree.
agentRules: false,
// Playwright runs both browser projects against one long-lived dev server.
// Retain route entries so later Firefox tests do not reference evicted chunks.
...(process.env.CI
Expand Down Expand Up @@ -34,6 +36,23 @@ const nextConfig = {
}
);

// @next/mdx registers its loader without an App Router layer, so .mdx misses
// Next's React aliasing and dev crashes on "ReactCurrentDispatcher of undefined".
const mdxRule = config.module.rules.find(
(rule) => rule?.test?.toString() === /\.mdx$/.toString()
);

if (mdxRule) {
mdxRule.resolve = {
...mdxRule.resolve,
alias: {
...mdxRule.resolve?.alias,
"react/jsx-runtime": "next/dist/compiled/react/jsx-runtime",
"react/jsx-dev-runtime": "next/dist/compiled/react/jsx-dev-runtime",
},
};
}

return config;
},
images: {
Expand Down
Loading
Loading