Skip to content

fix(worktree): keep seeded .claude settings placeholders out of git status - #377

Open
Seyamalam wants to merge 1 commit into
johannesjo:mainfrom
Seyamalam:fix/claude-settings-placeholder-exclude
Open

Seyamalam wants to merge 1 commit into
johannesjo:mainfrom
Seyamalam:fix/claude-settings-placeholder-exclude

Conversation

@Seyamalam

Copy link
Copy Markdown

🔗 Linked issue

Resolves #2914

🧭 Context

In the compare view, some values get a colored background (green/blue/yellow/red) based on rules like "published more than 2 years ago" or "more than 10 direct dependencies". The color signals that a value is noteworthy but doesn't say why, which is ambiguous — e.g. a yellow publish date gives no hint about the threshold behind it.

📚 Description

Facets that assign a non-neutral status now also set a tooltip explaining the rule behind the color (e.g. "This version was published over 2 years ago", "More than 10 direct dependencies", "Critical or high severity vulnerabilities found"). The explanation appears on hover/focus via the existing TooltipApp behavior.

Covered: package size & install size thresholds, direct & total dependency thresholds, stale publish date, missing license, module format, types (bundled / @types / none), vulnerability severity, and deprecated. Neutral and muted cells, and the "no dependency" baseline column, get no tooltip — there's no judgment to explain there.

Also: FacetCard (the mobile layout) now renders value.tooltip, previously only FacetRow did — so the explanations work on mobile too.

Strings live under compare.facets.status.* in en.json ({'@'}-escaped where needed), and i18n/schema.json was regenerated. Added a status tooltips suite to use-package-comparison.spec.ts covering the warning/good/bad paths and the neutral no-tooltip case.

After — hovering the amber "Published" cell for corser (before, the same hover showed nothing):

compare tooltip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant