feat(agent): add jwtsource package for reading projected SA tokens - #818
feat(agent): add jwtsource package for reading projected SA tokens#818roeezis wants to merge 1 commit into
Conversation
Introduces a small, isolated interface for reading a JWT from a file path — the first piece of the upcoming Conjur JWT authentication path, split out on its own since nothing else in this PR depends on it yet.
f441e36 to
ffa53d1
Compare
|
Fixed — switched both tests to |
|
@mladen-rusev-cyberark The only way to get true stacking would be to close #819-824 and reopen them on the fork itself (roeezis/jetstack-secure), each based on the previous branch — fully public and reviewable without needing write access to my fork. That loses the existing review-thread history on those 6 PRs though (several rounds of your feedback already resolved on them), so I didn't want to do that without flagging the tradeoff first. In the meantime: each PR's diff already shrinks to just its own delta once its predecessors merge (base is master, so the diff is against master's current state) — noted in each PR's description. If a maintainer merges these in order (818 → 819 → ... → 824), the stacking problem resolves itself without needing the close/reopen. Let me know if you'd rather I do the recreate anyway, or if merging in order as they're approved works for you. |
3 participants
Summary
Part 1 of the SMS/Conjur JWT authentication series (split out of #817 for reviewability).
Introduces a small, isolated interface for reading a JWT from a file path — the first piece of the upcoming Conjur JWT authentication path. Nothing else depends on it in this PR; the Conjur client that uses it lands later in the stack.
Test plan
go build ./...go test ./internal/cyberark/jwtsource/...