Repository navigation
Fix pending enum layout - #89
Merged
Merged
Conversation
Case items share the enum item's offset space, and the comparison starts each case at the enum's offset. Starting the case emitter at 0 encoded an extra skip equal to the enum's offset, so enums laid out inline at a nonzero offset compared the wrong bytes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Match AttributeGraph: an enum's layout is invalid if any case's children are invalid, not only when a case extends past the enum's size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The field is the offset in the value up to which layout entries have been emitted, not a size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nding A synchronous layout build that finds a nested enum's layout still queued visits the enum inline at a nonzero offset. Check that values differing in an enum payload still compare unequal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.