Skip to content

Rewrite IAG::vector to follow the implementation of llvm::SmallVector #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcmosc wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Rewrite IAG::vector to follow the implementation of llvm::SmallVector #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3d1992c
Fix over-release of inline vector elements after growing to the heap
jcmosc Oct 21, 2026
56a136f
Fix vector::front() returning a pointer instead of a reference
jcmosc Oct 21, 2026
7fb10c2
Fix shrink_to_fit freeing the elements of a vector without inline sto…
jcmosc Oct 21, 2026
8f1e0eb
Fix move assignment of vector of unique_ptr calling the wrong destructor
jcmosc Oct 21, 2026
c762fda
Move vector elements that aren't trivially copyable instead of memcpy…
jcmosc Oct 21, 2026
82042e8
Grow vector capacity like llvm::SmallVector
jcmosc Oct 21, 2026
9e591b0
Fix vector insert and erase operating on destroyed or uninitialized e…
jcmosc Oct 21, 2026
bb39998
Manage vector element lifetimes like llvm::SmallVector
jcmosc Oct 21, 2026
b81de33
Handle vector arguments that refer to elements of the same vector
jcmosc Oct 21, 2026
7bcc001
Implement clear() and pop_back() for vector of unique_ptr
jcmosc Oct 21, 2026
c7e8a04
Implement insert() of an rvalue for vector of unique_ptr
jcmosc Oct 21, 2026
f915e3c
Implement resize() for vector of unique_ptr
jcmosc Oct 21, 2026
e0a243d
Implement shrink_to_fit() for vector of unique_ptr
jcmosc Oct 21, 2026
d26179c
Delete vector of unique_ptr methods that would copy an element
jcmosc Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Sources/ComputeCxx/Comparison/Compare.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,11 @@ class Compare {
Enum(const Enum &) = delete;
Enum &operator=(const Enum &) = delete;

// Non-moveable
Enum(Enum &&) = delete;
// Move constructible so that vector can relocate it, the moved-from enum no longer owns anything
Enum(Enum &&other)
: type(std::exchange(other.type, nullptr)), enum_tag(other.enum_tag), lhs(other.lhs), rhs(other.rhs),
lhs_copy(other.lhs_copy), rhs_copy(other.rhs_copy), offset(other.offset), mode(other.mode),
owns_copies(std::exchange(other.owns_copies, false)) {};
Enum &operator=(Enum &&) = delete;
};

Expand Down
Loading
Loading