Skip to content

SRv6 on Junos - #3889

Open
ipspace wants to merge 4 commits into
devfrom
srv6-junos
Open

ipspace wants to merge 4 commits into
devfrom
srv6-junos

Conversation

@ipspace

@ipspace ipspace commented Sep 22, 2026

Copy link
Copy Markdown
Owner
  • SRv6 locator configuration
  • SRv6 locator advertisement with IS-IS
  • Layer-3 services (IPv4 + IPv6) with SRv6

* SRv6 locator configuration
* SRv6 locator advertisement with IS-IS
* Layer-3 services (IPv4 + IPv6) with SRv6
@ipspace
ipspace requested review from ssasso and a lite review from Copilot September 22, 2026 14:52

This comment was marked as outdated.

}
{% endif %}

{% if bgp.as is defined %}

@jbemmel jbemmel Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps if 'bgp' in srv6.igp or 'ebgp' in srv6.igp ?

FRR uses {% if bgp.srv6 is defined %}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code, I saw at least 3 different ways to check for when to enable BGP with SRv6 - this may be a good moment to consolidate

e.g. FRR has {% if 'bgp' in srv6.igp|default([]) or srv6.bgp|default(False) %} at the top and then something else below, etc.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code, I saw at least 3 different ways to check for when to enable BGP with SRv6 - this may be a good moment to consolidate

Agreed. Will do that after merging this one. You know how lovely it is to trace a bug in the code to a totally unrelated PR ;)

ipspace and others added 2 commits September 22, 2026 17:09
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

This comment was marked as outdated.

(This was easy, so why not ;)
ipspace added a commit that referenced this pull request Sep 22, 2026
@ipspace
ipspace requested a lite review from Copilot September 22, 2026 16:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The Junos SRv6 template has two unresolved moderate issues.

Review effort: Lite
Findings: None

Resolved since last review (3)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Missing SRv6 source address from IPv6 loopback

netsim/​ansible/​templates/​srv6/​junos.j2:3

This srv6 block never configures Junos's source-address, so SRv6 encapsulation/service SIDs have no source IPv6 address; the SRv6 template contract requires deriving it from loopback.ipv6 (as the other SRv6 templates do). Add the address-only loopback value here.

This issue also appears on line 11 of the same file.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants