Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: internal
What is the current behavior?
strictis off. Turning it on reports 144 errors across 21 files, so much ofsrc/is implicitlyanyand unchecked.Docusaurus v4 requires TypeScript 6, where
strictdefaults to on, so this work is on the critical path for that upgrade rather than optional.What is the new behavior?
"strict": true, at zero errors.The config change is one line. The other 25 files are the 144 errors it surfaced, and they collapse into a few causes:
propswith no annotation. Most becameComponentProps<'div'>or similar.generateColordeclared it returnedColorVariable, whose fields are all optional, while it populates every one. Three iframe helpers tookHTMLIFrameElementdespite each already having anif (frame)guard inside. TwouseState([])calls inferrednever[].MdxContentwas typed() => {}, which is not renderable.Does this introduce a breaking change?
Other information
Real bugs surfaced, all previously invisible because the surrounding code was
any:aria-hidden={... : null}in four places. React omits an attribute forundefined;nullis not an accepted value.ref={(tabControl) => tabRefs.push(tabControl)}. React 19 reads a returned value as a cleanup function.