Revert "cpp: do not pass #error into output stream, warn about it and exit non-0" - #3
Open
citrus-it wants to merge 1 commit into
Open
Revert "cpp: do not pass #error into output stream, warn about it and exit non-0"#3citrus-it wants to merge 1 commit into
citrus-it wants to merge 1 commit into
Conversation
… exit non-0" This reverts commit ee5767d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ee5767d.
This commit seems wrong.
With it, if you compile
cppwithoutEXIT_ON_ERRORdefined,cppjust doesn't understand#errorat all and outputs things like this during a gate build:With
EXIT_ON_ERRORset, a gate build fails with:I think it's wrong to have a switch with toggles between "#error not understood" and "#error acted upon" and we should revert to "#error passed through to output stream" (as per OmniOS and SmartOS today) and "#error acted upon" - and then we can work on making the latter work with a gate build.