Skip to content

HQD-736: run tests on GitHub Actions with PHP 8.5 - #41

Merged
SilverFire merged 1 commit into
masterfrom
hqd-736-gha-php85
Nov 13, 2026
Merged

SilverFire merged 1 commit into
masterfrom
hqd-736-gha-php85

Conversation

@SilverFire

@SilverFire SilverFire commented Nov 13, 2026 •

Copy link
Copy Markdown
Member
  • Remove dead Travis CI and Scrutinizer configs and their README badges.
  • Add .github/workflows/tests.yml: PHPUnit on PHP 8.5.
  • require-dev: drop hiqdev/hidev-php, hiqdev/hidev-hiqdev (do not install on Composer 2) and vimeo/psalm ^3 (conflicts with PHPUnit 12, unused); allow laminas-diactoros ^3 and laminas-httphandlerrunner ^2 (v1/v2 do not support PHP 8.5); add yiisoft/yii2 and lcobucci/content-negotiation-middleware, which src classes under test use and previously came in transitively via hidev.
  • tests/_bootstrap.php: boot the Yii application only when the config plugin is available, so the unit suite runs standalone (no test uses Yii::$app).

Summary by CodeRabbit

  • Tests
    • Automated tests now run on pushes to the main branch and on pull requests, using PHP 8.5 and PHPUnit.
  • Chores
    • Removed the previous CI and code-quality reporting configurations, along with their README badges.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request adds a GitHub Actions workflow to install dependencies and run PHPUnit. It updates Composer development dependencies and test bootstrap behavior, and removes the Travis CI and Scrutinizer configurations and related README badges.

Changes: PHP test and CI updates

Layer / File(s) Summary
Development dependencies and test bootstrap
composer.json, tests/_bootstrap.php
Composer development dependencies and plugin permissions change. The test bootstrap loads web configuration only after autoloading and Yii setup, and returns early when Builder is unavailable.
GitHub Actions workflow and legacy CI removal
.github/workflows/tests.yml, .travis.yml, .scrutinizer.yml, README.md
A GitHub Actions workflow runs PHPUnit after dependency installation. The Travis CI and Scrutinizer configurations and related README badges are removed.

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Other

Suggested reviewers: tafid

Merge Risk: Minimal · up to 19752

This change moves test runs to GitHub Actions on PHP 8.5, updates development dependencies and makes the test bootstrap tolerant of a missing config plugin. It touches no production runtime code. No concrete merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: adding a GitHub Actions test workflow that runs PHPUnit on PHP 8.5. It also includes the ticket key HQD-736, which is acceptable. The changeset matches this, since it …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: adding a GitHub Actions test workflow that runs PHPUnit on PHP 8.5. It also includes the ticket key HQD-736, which is acceptable. The changeset matches this, since it adds .github/workflows/tests.yml configured for PHP 8.5 and removes the Travis and Scrutinizer setup that the title does not mention.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7c09af8f-6b48-4fc5-a570-731fd5785684
Commits

Reviewing files that changed from the base of the PR and between c3abc58 and 19752a0.

Files selected for processing: 6

  • .github/workflows/tests.yml
  • .scrutinizer.yml
  • .travis.yml
  • README.md
  • composer.json
  • tests/_bootstrap.php
Files with no reviewable changes: 3

  • .scrutinizer.yml
  • .travis.yml
  • README.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@SilverFire
SilverFire merged commit 0877a72 into master Nov 13, 2026
2 of 3 checks passed
@SilverFire
SilverFire deleted the hqd-736-gha-php85 branch November 13, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant