fix: only send load balancer service health_check properties when defined - #691
Merged
Merged
Conversation
…ined The code was sending all the health_check properties unconditionally, which prevented from falling back on API defaults or to partially update the health_check values.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
=======================================
Coverage 97.12% 97.12%
=======================================
Files 76 76
Lines 4099 4099
=======================================
Hits 3981 3981
Misses 118 118 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jooola
pushed a commit
that referenced
this pull request
Sep 17, 2026
<!-- section-start changelog --> ### Bug Fixes - only send load balancer service health_check properties when defined (#691) ([e3bf6f2](e3bf6f2)) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ~~~~rp-prefix ~~~~ ### Suffix / End This will be added to the end of the release notes. ~~~~rp-suffix ~~~~ </details> Co-authored-by: Hetzner Cloud Bot <>
jooola
added a commit
that referenced
this pull request
Sep 17, 2026
jooola
added a commit
to ansible-collections/hetzner.hcloud
that referenced
this pull request
Sep 17, 2026
…lth_check argument (#873) ##### SUMMARY The issue was fixed in hcloud-python hetznercloud/hcloud-python#691, but we want to have a regression test for #158 and a changelog for the users. We also marked the load balancer service `health_check.port` and `health_check.protocol` arguments are required to reflect the API requirements. Closes #158 ##### COMPONENT NAME load_balancer_service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was sending all the health_check properties unconditionally, which prevented from falling back on API defaults or to partially update the health_check values.