Skip to content

Ensure X509 data is being freed #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrey-kashcheev merged 1 commit into from
Sep 10, 2026
Merged

Ensure X509 data is being freed #1725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions olp-cpp-sdk-core/src/http/curl/NetworkCurl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,11 @@ int Md5LookupGetBySubject(X509_LOOKUP* ctx, X509_LOOKUP_TYPE type,
// Update return result
auto* x509_data = X509_new();
X509_set_subject_name(x509_data, name);
X509_OBJECT_set1_X509(ret, x509_data);
// set1 takes its own reference; release ours to avoid a per-lookup leak.
const auto set_ret = X509_OBJECT_set1_X509(ret, x509_data);
X509_free(x509_data);

return 1;
return set_ret;
}
#endif

Expand Down
Loading