Repository navigation
chore(suidhelper): more type-safe utilities - #173
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
markovejnovic
force-pushed
the
fix/suidhelper-full-root-tools
branch
from
November 16, 2026 02:56
f053b10 to
b0cad9b
Compare
…ange The host forward chain dropped ct state invalid only for traffic from VM veths, so an invalid segment from the internet to 10.200.0.0/16 was forwarded.
Dmsetup and ThinDump now take the Root guard and spawn through spawn_as_root, so the tool runs with real, effective and saved ids 0, groups [0] and no caller fds beyond its own binary and thin_dump's metadata device. Previously only the environment was cleared: the caller's real uid/gid, supplementary groups and open fds reached the root tool.
Pull the thin-pool table check out of ThinPool::open so the unprivileged suite can refuse non-pool tables directly. The remaining dmsetup spawns need genuine root and are excluded, naming the _as_root tests that kill them in the privileged job.
markovejnovic
force-pushed
the
fix/suidhelper-full-root-tools
branch
from
November 16, 2026 03:16
b0cad9b to
9203fcc
Compare
markovejnovic
marked this pull request as ready for review
November 16, 2026 03:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.