Skip to content

chore(suidhelper): more type-safe utilities - #173

Merged
markovejnovic merged 8 commits into
mainfrom
fix/suidhelper-full-root-tools
Nov 16, 2026
Merged

markovejnovic merged 8 commits into
mainfrom
fix/suidhelper-full-root-tools

Conversation

@markovejnovic

@markovejnovic markovejnovic commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Test Results

    4 files  ± 0    336 suites  +3   3m 49s ⏱️ -5s
1 593 tests +54  1 593 ✅ +54    0 💤 ±0  0 ❌ ±0 
2 216 runs  +54  1 593 ✅ +54  623 💤 ±0  0 ❌ ±0 

Results for commit 9203fcc. ± Comparison against base commit 2ce40a9.

♻️ This comment has been updated with latest results.

@markovejnovic
markovejnovic force-pushed the fix/suidhelper-full-root-tools branch from f053b10 to b0cad9b Compare November 16, 2026 02:56
…ange

The host forward chain dropped ct state invalid only for traffic from VM veths, so an invalid segment from the internet to 10.200.0.0/16 was forwarded.
Dmsetup and ThinDump now take the Root guard and spawn through spawn_as_root, so the tool runs with real, effective and saved ids 0, groups [0] and no caller fds beyond its own binary and thin_dump's metadata device. Previously only the environment was cleared: the caller's real uid/gid, supplementary groups and open fds reached the root tool.
Pull the thin-pool table check out of ThinPool::open so the unprivileged
suite can refuse non-pool tables directly. The remaining dmsetup spawns
need genuine root and are excluded, naming the _as_root tests that kill
them in the privileged job.
@markovejnovic
markovejnovic force-pushed the fix/suidhelper-full-root-tools branch from b0cad9b to 9203fcc Compare November 16, 2026 03:16
@markovejnovic
markovejnovic marked this pull request as ready for review November 16, 2026 03:31
@markovejnovic markovejnovic changed the title fix(suidhelper): run root tools as genuine root; roll back half-raised privilege; drop INVALID forwards chore(suidhelper): more type-safe utilities Nov 16, 2026
@markovejnovic
markovejnovic merged commit a9da789 into main Nov 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant