Skip to content

fix(agent): keep the caller's exec deadline end to end and clean up every exit path - #168

Merged
markovejnovic merged 3 commits into
mainfrom
fix/agent-exec-deadline
Nov 16, 2026
Merged

markovejnovic merged 3 commits into
mainfrom
fix/agent-exec-deadline

Conversation

@markovejnovic

@markovejnovic markovejnovic commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 5 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/hyper/node/fire_vmm/agent.ex 90.90% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Test Results

    4 files  ± 0    265 suites  +8   2m 47s ⏱️ -28s
1 223 tests +15  1 223 ✅ +15    0 💤 ± 0  0 ❌ ±0 
1 788 runs  +30  1 223 ✅ +15  565 💤 +15  0 ❌ ±0 

Results for commit 39ee159. ± Comparison against base commit 572b0a8.

♻️ This comment has been updated with latest results.

@markovejnovic
markovejnovic force-pushed the fix/agent-exec-deadline branch from 3878bad to 6312523 Compare November 16, 2026 01:43
@markovejnovic
markovejnovic changed the base branch from main to deps/grpc-1.1 November 16, 2026 01:43
…very exit path

Run the unary Exec RPC over a caller-owned gun connection: grpc-timeout rounded up from the caller's :timeout, one deadline over connect and reply, unreachable relay is :agent_unavailable, CANCELLED "Timeout expired" is :timeout, and the connection closes on return or caller death with no stray messages.
@markovejnovic
markovejnovic force-pushed the fix/agent-exec-deadline branch from 6312523 to 39ee159 Compare November 16, 2026 01:47
@markovejnovic
markovejnovic changed the base branch from deps/grpc-1.1 to main November 16, 2026 01:47
@markovejnovic markovejnovic reopened this Nov 16, 2026
@markovejnovic
markovejnovic marked this pull request as ready for review November 16, 2026 02:26
@markovejnovic
markovejnovic merged commit 53ec1c9 into main Nov 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant