Conversation
eggyShrimp
reviewed
Sep 22, 2026
| } | ||
| // 使用环境变量判断是在cursor里面打开的 | ||
| if ( | ||
| (env.VSCODE_GIT_ASKPASS_NODE && env.VSCODE_GIT_ASKPASS_NODE.includes('cursor')) || |
Contributor
There was a problem hiding this comment.
这里 ai 审查了下，includes('cursor')) 这里不区分大小写有些问题。
VSCODE_GIT_ASKPASS_NODE 变量是 编辑器 注入的软件安装路径（https://github.com/microsoft/vscode/blob/94a39f4cb65288f75dfeeb9a4aa0e7146244e33c/extensions/git/src/askpass.ts#L40），但同时 cursor 在 macos 上的安装路径用的是 “Cursor”。
所以对于 macos cursor，落盘直接进到 other
| } | ||
|
|
||
| /** | ||
| * 判断当前工程是在哪一个ide里面打开的 |
Contributor
There was a problem hiding this comment.
不是那么严谨，看起来不是 “判断当前工程是在哪一个ide里面打开的”，而是 “判断当前 hap-toolkit 在哪里编译工程”
added 2 commits
September 23, 2026 14:14
eggyShrimp
approved these changes
Sep 23, 2026
无license information测试产物更新
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.