fix: propagate application write rejections as ATT Error Responses (backport to 2.5) - #444
Open
jie-meng wants to merge 1 commit into
Open
Conversation
…ackport to 2.5) Backport of h2zero#442 to the release/2.5 branch. - NimBLECharacteristic: Added setWriteError(uint8_t) and getWriteError() const - NimBLECharacteristic::writeEvent(): Resets error slot before each write - NimBLEServer::handleGattEvent(): Returns write error for characteristic writes Co-authored-by: Jie Meng <jmengxy@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #442 to the release/2.5 branch.
Summary
This backports the fix for propagating application-layer write rejections as ATT Error Responses to the 2.5 release branch.
Changes
Usage
Applications can now reject writes in onWrite() callbacks:
Testing
@h2zero - this is the backport requested in #442 comment. Would appreciate a review/merge when you have cycles.