Restore Google sign-in retry state for reject and no-navigation paths - #2050
groupthinking with Copilot wants to merge 2 commits into
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: groupthinking/EventRelay/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔍 PR Validation |
Canonical issue
Linked by automation.
Outcome
Google sign-in now reliably recovers to a retryable state when initiation fails or resolves without starting navigation, while preserving the in-flight disabled state when redirect does start.
Scope
signInmicro-wait before deciding whether navigation started, preventing false retry/error UI during deferred redirect start.signInresolves, navigation begins on next tick) to lock in duplicate-click protection and no-error behavior.Risk
apps/web/src/app/login/GoogleSignInButton.tsxandapps/web/src/app/login/GoogleSignInButton.test.tsxto previous revision.Verification
Head SHA:
a627bb2f3f997a5b38cf8fdb960429170eeeaf27Focused checks executed:
npm --workspace=apps/web run test -- src/app/login/GoogleSignInButton.test.tsx src/lib/__tests__/auth-paths.test.ts src/lib/__tests__/auth-config-source.test.ts src/__tests__/proxy-auth-gate.test.tsnpm --workspace=apps/web run lintnpm --workspace=apps/web run type-checknpm --workspace=apps/web run buildFocused tests
Required CI
Review threads resolved
Production evidence
Not applicable for this change set (UI state + unit/regression coverage; no runtime config or deployment behavior change).
Agent handoff