Skip local training and embedding disk access on Vercel - #2049
Open
groupthinking with Copilot wants to merge 3 commits into
Open
groupthinking with Copilot wants to merge 3 commits into
groupthinking with Copilot wants to merge 3 commits into
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: groupthinking/EventRelay/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Avoid local storage writes for Vercel serverless runtime
Skip local training and embedding disk access on Vercel
Sep 18, 2026
github-actions
Bot
added
javascript
Contributor
🔍 PR Validation |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
groupthinking
approved these changes
Sep 18, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approved
The focused guard changes match the stated scope and are covered for both local stores.
Review effort: Balanced
Findings: None
What changed in this PR
Updates local training and embedding stores to avoid filesystem access in Vercel deployments.
Changes:
- Detect Vercel through either
VERCEL=1or non-emptyVERCEL_ENV. - Add regression coverage confirming both stores make no filesystem calls in preview environments.
| File | Description |
|---|---|
apps/web/src/lib/training-store.ts |
Broadens Vercel runtime detection. |
apps/web/src/lib/embedding-store.ts |
Broadens Vercel runtime detection. |
apps/web/src/lib/__tests__/serverless-local-store.test.ts |
Tests serverless filesystem bypass behavior. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Contributor
Dependency Review SummaryThe full dependency review summary was too large to display here (13153KB, limit is 1024KB). Please download the artifact named "dependency-review-summary" to view the complete report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
Automated issue linkage is handled separately.
Outcome
Vercel serverless executions stop attempting local training/embedding filesystem access, eliminating the
ENOENTmkdir/read noise from those code paths.Scope
apps/web/src/lib/training-store.tsandapps/web/src/lib/embedding-store.tsto recognize deployed Vercel environments viaVERCEL_ENV, not justVERCEL=1.VERCEL_ENV=previewand asserting nofs.promisescalls occur.Risk
VERCEL_ENVis set unexpectedly outside Vercel, local training/embedding disk persistence will be skipped for that process.Verification
List exact automated and manual checks, tied to the current head SHA.
npm --workspace=apps/web run test -- src/lib/__tests__/serverless-local-store.test.ts src/app/api/v1/refinery/dataset/__tests__/route.test.ts@86b36e5Production evidence
Not applicable. This is a runtime guard adjustment for Vercel serverless filesystem behavior; no preview-only UI or infrastructure evidence was required.
Agent handoff