Normalize E2E probe run IDs for stable Vercel attribution - #2047
groupthinking with Copilot wants to merge 2 commits into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: groupthinking/EventRelay/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔍 PR Validation |
There was a problem hiding this comment.
Copilot review overview
🟢 Approved
The implementation matches the proxy contract and includes focused regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Normalizes E2E run IDs so attribution headers consistently match the existing Vercel proxy pattern.
Changes:
- Sanitizes and caps run IDs at 64 characters.
- Adds regression tests for normalization and truncation.
| File | Description |
|---|---|
tests/e2e/pipeline.test.ts |
Normalizes E2E attribution tokens and tests edge cases. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dependency Review SummaryThe full dependency review summary was too large to display here (13153KB, limit is 1024KB). Please download the artifact named "dependency-review-summary" to view the complete report. |
Canonical issue
Outcome
E2E requests now emit a proxy-matchable
User-Agenttoken on every request, even ifGITHUB_RUN_IDcontains punctuation, whitespace, or overlong values. This preserves boundede2e_probe_requestattribution in Vercel logs without changing ordinary request handling.Scope
[A-Za-z0-9._-], and cap to 64 chars before settingUser-Agent.apps/web/src/proxy.tsRisk
tests/e2e/pipeline.test.tsharness change.Verification
List exact automated and manual checks, tied to the current head SHA
6de619de4242.npx vitest run tests/e2e/pipeline.test.tsnpm --workspace=apps/web run test -- src/__tests__/proxy-auth-gate.test.tsProduction evidence
Not directly applicable: this change tightens the E2E harness token format and validates compatibility with the existing bounded proxy log path; it does not change deploy/runtime infrastructure or introduce a new production surface.
Agent handoff